Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(contributors): add Twitter & Mastodon icons #102

Open
SohamRatnaparkhi opened this issue May 27, 2023 · 10 comments
Open

feat(contributors): add Twitter & Mastodon icons #102

SohamRatnaparkhi opened this issue May 27, 2023 · 10 comments
Assignees

Comments

@SohamRatnaparkhi
Copy link
Member

The Notion table contains Twitter as well but it hasn't been integrated on the page where contributors as displayed.
Solving this issue involves working in Contributors folder:

  • Finding a Twitter SVG logo in light and dark theme
  • Expected behavior is the same as for GitHub, LinkedIn etc
@SohamRatnaparkhi SohamRatnaparkhi self-assigned this May 27, 2023
@uniqueg
Copy link
Member

uniqueg commented May 28, 2023

Could you try to add Mastodon as well, while you're at it? 🙏

@uniqueg
Copy link
Member

uniqueg commented Jun 14, 2023

Any update on this, @SohamRatnaparkhi?

@uniqueg uniqueg changed the title [feat]: Add Twitter icon and functionality on contributors view page feat: add Twitter, Mastodon icons for contributors Jun 14, 2023
@uniqueg uniqueg changed the title feat: add Twitter, Mastodon icons for contributors feat(contributors): add Twitter & Mastodon icons Jun 14, 2023
@SohamRatnaparkhi
Copy link
Member Author

Any update on this, @SohamRatnaparkhi?

Hey @uniqueg
Sorry for holding on this issue so late. I am currently busy in a different venture so I wasn't able to get back to this. I am okay if some else takes up this issue.

@uniqueg
Copy link
Member

uniqueg commented Jun 15, 2023

Okay, sure - no worries :) Thanks a lot!

@valens200
Copy link
Contributor

@uniqueg please assign this issue to me

@uniqueg
Copy link
Member

uniqueg commented Jan 11, 2024

Thanks a lot, @valens200 🙏

@valens200
Copy link
Contributor

The Notion table contains Twitter as well but it hasn't been integrated on the page where contributors as displayed. Solving this issue involves working in Contributors folder:

  • Finding a Twitter SVG logo in light and dark theme
  • Expected behavior is the same as for GitHub, LinkedIn etc

Hi, can you please provide more info on this issue?

@uniqueg
Copy link
Member

uniqueg commented Jan 22, 2024

Twitter and Mastodon profiles are available as full URLs (e.g., https://twitter.com/someuser or https://some.instance/@someuser) from the Notion table under Twitter and Mastodon, just like they are for Linkedin, Orcid, Scholar, Researchgate etc.

Do you need any other info?

I think @git-anurag-hub can tell you where to best find icons/logos. When dealing with these, note that you may need two versions to handle light and dark mode. But again, you can see how this is done for the other social media icons.

@valens200
Copy link
Contributor

valens200 commented Jan 22, 2024

@uniqueg the problem is not where to find those icons, but I can't even see the page where they are needed. If I was able to find that page, I would have even fixed the issue completely.

@uniqueg
Copy link
Member

uniqueg commented Jan 22, 2024

This PR implemented the other social media links: #14

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants