Revert "Fix broken tests (#85)" because the PR actually breaks tests #88
Conversation
This reverts commit dde4eb0.
Vinai
changed the title
|
@Vinai your comments make sense. I am assuming that you were testing on a local setup? I was testing against https://hyva-demo.elgentos.io/ since I don't have a local Hyva setup (We are still on Luma for now...) and this suite was set to run again that site. I had made the (perhaps wrong) assumption that https://hyva-demo.elgentos.io/ was Hyva standard setup running Magento 2.4 with Hyva 1.1.17. Perhaps there has actually been a change to the site that caused the tests to break and instead of changing the tests the site needs to be updated? @peterjaap has there been any recent changes to https://hyva-demo.elgentos.io/. If changes have been made then yeah we should revert my PR and update the site. I did confirm again that all tests still pass in CI with my version. (See screenshot below) I ran this against my own Cypress Project since I don't think I have permissions to run in this repo.
|
|
@zephanhazell I am running the tests against a fresh M2 + Hyvä install in CI in addition to a local installation. It would indeed be interesting to know in what way https://hyva-demo.elgentos.io/ is different. |
|
@Vinai I put the version numbers on the homepage;
So maybe it has something to do with Elasticsuite? It's still on my todo list to spin up a vanilla Magento + Hyva instance inside Github Actions but haven't come round to it yet. |
|
I agree Elastic is the likely culprit. |
|
@Vinai but these 3 tests that belong to this PR are also broken. Right now, it looks like a few tests are breaking across a few PR's. This one and these two; https://github.com/elgentos/magento2-cypress-testing-suite/actions/runs/3124107340/jobs/5067186108, https://github.com/elgentos/magento2-cypress-testing-suite/actions/runs/3169801806/jobs/5161956622 |
|
I am closing this issue because as far as I can see, nothing is broken at the moment. Here's the latest run result; https://dashboard.cypress.io/projects/8vuidn/runs/e0a3cf9c-9653-4b03-97cc-04178dd6adb8/test-results/044b4dba-9ee4-43ec-8db0-6fcf12c95df5 |
This reverts commit dde4eb0.
Closes issue #87