Show when location services are in use #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
danirabbit
commented
Jun 17, 2024
danirabbit
commented
|
I thought indication of location use is already implemented in the privacy indicator, which we've never shipped IIRC. 🤔 |
|
@ryonakano yeah exactly it was never shipped. I'm trying to get away from having separate indicators that only show sometimes because it means their popover items are only available sometimes and overall trying to work towards a quick settings popover that's more in line with what other major platforms provide |
ryonakano
reviewed
Jun 17, 2024
|
|
||
| setup_geoclue_manager.begin ((obj, res) => { | ||
| var geoclue_manager = setup_geoclue_manager.end (res); | ||
| location_revealer.reveal_child = geoclue_manager.in_use; |
There was a problem hiding this comment.
I think we need a null check here since setup_geoclue_manager can return null.
| @@ -0,0 +1,41 @@ | |||
| public class QuickSettings.TattleBox : Gtk.Bin { | |||
There was a problem hiding this comment.
It looks like we're missing the copyright header.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.