Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TextScale: use a single toggle #28

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

danirabbit
Copy link
Member

Screenshot from 2024-03-12 12 34 15

  • Matches an expressed user desire to quickly toggle between normal and large text. (Use case was a presenter who wanted to be able to quickly enlarge and restore text while presenting)
  • Uses a single toggle which fits in better with other potential sliders like sound and brightness

@danirabbit danirabbit requested a review from a team March 12, 2024 19:43
Copy link
Contributor

@jeremypw jeremypw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using the toggle works as expected provided only if you pay careful attention to the icon on it - it not very obvious whether pressing it will increase or decrease the font size as it depends on the scale position. If the toggle is meant to be a "increase font size" toggle then maybe it should always increase the font size above what ever the current scale setting is?

@danirabbit
Copy link
Member Author

@jeremypw Yeah I'm not sure of a better way to meet the desire here which is switching between large text and quickly reverting back to normal size text. There is only one text scale setting, so I can only scale back to the default value or some multiple of it. If your text size is already set to something larger than the default, I don't know how we can determine that it's because that's your "normal" text or if it's "large" text that we then need to revert when the setting is toggled 🤔 Open to suggestions about how to handle that better

@danirabbit
Copy link
Member Author

Actually now that I think about it, maybe the text size setting in System Settings should be changing the font and not the text scaling factor. Then we could have a way to differentiate between what is your default text size and what is a temporary scaling

@jeremypw
Copy link
Contributor

Actually now that I think about it, maybe the text size setting in System Settings should be changing the font and not the text scaling factor. Then we could have a way to differentiate between what is your default text size and what is a temporary scaling

Sounds like a plan :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants