-
-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consistency improvement with dock menu item #622
base: master
Are you sure you want to change the base?
Conversation
While i was working to improve consistency i did a fourth commit, that, uh, could be discared if unwanted ? Current behaviour: With this commit: |
Comments should usually be used to explain "why" if something is non-obvious. In this case things like Likewise something like "create menu item" right above If you wanted to annotate the purpose of a class, that comment should be at the top of the class file. So for example explaining what a See also: https://docs.vala.dev/developer-guides/documentation/valadoc-guide/01-00-quick-start.html |
More of a visual help. Should i do a commit to delete them all ? It doesnt take long. |
@teamcons I would remove comments that say the same thing that the code already says and leave in comments that explain why a thing is done or something that is not-obvious or counterintuitive |
Fixes #620
Ive tested both changing state in the dock and appmenu, for several apps, several times - it works.
Second commit removes usage of the "docked" variable, state would be tracked by the checkmenuitem state - more variables to keep in sync means more variables to keep track of and more opportunities for bugs down the line.
If you prefer keeping it, first commit works on its own.
i hope there arent too much new comments ? Needed to understand how its done and navigate. It may make the file new friendly for new contributors, but should have been its own separate commit.