ELE-3709: Use get_report_link from alert class (#1722)

* use class method * lint
elementary-data · Oct 29, 2024 · e18f353 · e18f353
1 parent 1f4e91c
commit e18f353
Showing 1 changed file with 10 additions and 17 deletions.
diff --git a/elementary/monitor/data_monitoring/alerts/integrations/slack/slack.py b/elementary/monitor/data_monitoring/alerts/integrations/slack/slack.py
@@ -22,9 +22,7 @@
     SlackAlertMessageSchema,
 )
 from elementary.monitor.data_monitoring.alerts.integrations.utils.report_link import (
-    get_model_runs_link,
     get_model_test_runs_link,
-    get_test_runs_link,
 )
 from elementary.tracking.tracking_interface import Tracking
 from elementary.utils.json_utils import (
@@ -148,9 +146,8 @@ def _get_dbt_test_template(
                 ),
             )
 
-        test_runs_report_link = get_test_runs_link(
-            alert.report_url, alert.elementary_unique_id
-        )
+        test_runs_report_link = alert.get_report_link()
+
         if test_runs_report_link:
             report_link = self.message_builder.create_context_block(
                 [
@@ -314,9 +311,8 @@ def _get_elementary_test_template(
                 ),
             )
 
-        test_runs_report_link = get_test_runs_link(
-            alert.report_url, alert.elementary_unique_id
-        )
+        test_runs_report_link = alert.get_report_link()
+
         if test_runs_report_link:
             report_link = self.message_builder.create_context_block(
                 [
@@ -461,9 +457,8 @@ def _get_model_template(
                 ),
             )
 
-        model_runs_report_link = get_model_runs_link(
-            alert.report_url, alert.model_unique_id
-        )
+        model_runs_report_link = alert.get_report_link()
+
         if model_runs_report_link:
             report_link = self.message_builder.create_context_block(
                 [
@@ -565,9 +560,8 @@ def _get_snapshot_template(
                 ),
             )
 
-        model_runs_report_link = get_model_runs_link(
-            alert.report_url, alert.model_unique_id
-        )
+        model_runs_report_link = alert.get_report_link()
+
         if model_runs_report_link:
             report_link = self.message_builder.create_context_block(
                 [
@@ -653,9 +647,8 @@ def _get_source_freshness_template(
                 ),
             )
 
-        test_runs_report_link = get_test_runs_link(
-            alert.report_url, alert.source_freshness_execution_id
-        )
+        test_runs_report_link = alert.get_report_link()
+
         if test_runs_report_link:
             report_link = self.message_builder.create_context_block(
                 [