Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sliding Sync: Lazy-loading room members on incremental sync (remember memberships) #17809

Open
wants to merge 31 commits into
base: develop
Choose a base branch
from
Open

Sliding Sync: Lazy-loading room members on incremental sync (remember memberships) #17809

wants to merge 31 commits into from
+825 −58

Commits on Oct 3, 2024

  1. Correctly changes to required state config 

    Fixes #17698
    @erikjohnston
    erikjohnston committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    af9c72d View commit details
    Browse the repository at this point in the history

  2. Add tests

    @erikjohnston
    erikjohnston committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    2fd3a5a View commit details
    Browse the repository at this point in the history

  3. Newsfile

    @erikjohnston
    erikjohnston committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    5e66e98 View commit details
    Browse the repository at this point in the history

Commits on Oct 9, 2024

  1. Sliding Sync: Parameterize and add more tests for tracking changes to… 

    … required state (#17805)

Parameterize and add more tests for tracking changes to required state
(`_required_state_changes(...)`)

These are direct modifications to
#17785 and should be merged
into that PR.
    @MadLittleMods
    MadLittleMods authored Oct 9, 2024
    Configuration menu
    Copy the full SHA
    596581a View commit details
    Browse the repository at this point in the history

  2. Apply suggestions from code review 

    Co-authored-by: Eric Eastwood <[email protected]>
    @erikjohnston @MadLittleMods
    erikjohnston and MadLittleMods authored Oct 9, 2024
    Configuration menu
    Copy the full SHA
    4b631a5 View commit details
    Browse the repository at this point in the history

  3. Fixup

    @erikjohnston
    erikjohnston committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    e913037 View commit details
    Browse the repository at this point in the history

  4. comment __bool__

    @erikjohnston
    erikjohnston committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    35532d6 View commit details
    Browse the repository at this point in the history

  5. Fix handling of your own user ID

    @erikjohnston
    erikjohnston committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    859d4a8 View commit details
    Browse the repository at this point in the history

  6. Remove unused var

    @erikjohnston
    erikjohnston committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    56565dc View commit details
    Browse the repository at this point in the history

  7. Remove TODOs

    @erikjohnston
    erikjohnston committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    0d0207e View commit details
    Browse the repository at this point in the history

  8. Move comment down

    @erikjohnston
    erikjohnston committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    fafb2fe View commit details
    Browse the repository at this point in the history

  9. Clarify None comment

    @erikjohnston
    erikjohnston committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    c23d326 View commit details
    Browse the repository at this point in the history

  10. LAZY only applies to memberships

    @erikjohnston
    erikjohnston committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    6391b0f View commit details
    Browse the repository at this point in the history

  11. Lazy-loading room members on incremental sync (remember memberships)

    @MadLittleMods
    MadLittleMods committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    fbe9894 View commit details
    Browse the repository at this point in the history

  12. Add changelog

    @MadLittleMods
    MadLittleMods committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    b9a8780 View commit details
    Browse the repository at this point in the history

  13. Re-use invalidated_state_keys

    @MadLittleMods
    MadLittleMods committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    760810f View commit details
    Browse the repository at this point in the history

  14. Better clarify $ME translation

    @MadLittleMods
    MadLittleMods committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    ddc9769 View commit details
    Browse the repository at this point in the history

  15. Fill in TODO

    @MadLittleMods
    MadLittleMods committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    8b906c4 View commit details
    Browse the repository at this point in the history

  16. Fix grammar

    @MadLittleMods
    MadLittleMods committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    2080cc5 View commit details
    Browse the repository at this point in the history

  17. Move prev_room_sync_config up

    @MadLittleMods
    MadLittleMods committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    0087ad2 View commit details
    Browse the repository at this point in the history

Commits on Oct 10, 2024

  1. Move prev_room_sync_config up

    @MadLittleMods @erikjohnston
    MadLittleMods authored and erikjohnston committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    f8feef5 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'develop' into erikj/ss_required_state

    @erikjohnston
    erikjohnston authored Oct 10, 2024
    Configuration menu
    Copy the full SHA
    a566347 View commit details
    Browse the repository at this point in the history

  3. Comment why we're making new sets 

    See #17809 (comment)
    @MadLittleMods
    MadLittleMods committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    4e662da View commit details
    Browse the repository at this point in the history

  4. Merge branch 'erikj/ss_required_state' into madlittlemods/sliding-syn… 

    …c-lazy-load-members-on-incrental-sync3

Conflicts:
	synapse/handlers/sliding_sync/__init__.py
    @MadLittleMods
    MadLittleMods committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    fb5bca4 View commit details
    Browse the repository at this point in the history

Commits on Oct 14, 2024

  1. Merge branch 'develop' into madlittlemods/sliding-sync-lazy-load-memb… 

    …ers-on-incrental-sync3

Conflicts:
	synapse/handlers/sliding_sync/__init__.py
	tests/handlers/test_sliding_sync.py
    @MadLittleMods
    MadLittleMods committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    7e667fe View commit details
    Browse the repository at this point in the history

Commits on Oct 16, 2024

  1. Limit the number of state_keys that we remember 

    See #17809 (comment)
    @MadLittleMods
    MadLittleMods committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    aec7455 View commit details
    Browse the repository at this point in the history

  2. Update comments

    @MadLittleMods
    MadLittleMods committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    87497c8 View commit details
    Browse the repository at this point in the history

  3. Fix bug when requesting more than we can remember

    @MadLittleMods
    MadLittleMods committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    525222b View commit details
    Browse the repository at this point in the history

  4. Merge branch 'develop' into madlittlemods/sliding-sync-lazy-load-memb… 

    …ers-on-incrental-sync3
    @MadLittleMods
    MadLittleMods committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    90f0741 View commit details
    Browse the repository at this point in the history

  5. Fix bug remembering too much when over limit

    @MadLittleMods
    MadLittleMods committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    96c9a91 View commit details
    Browse the repository at this point in the history

Commits on Oct 17, 2024

  1. Merge branch 'develop' into madlittlemods/sliding-sync-lazy-load-memb… 

    …ers-on-incrental-sync3
    @MadLittleMods
    MadLittleMods committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    cf13ca0 View commit details
    Browse the repository at this point in the history