Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sliding Sync: Parameterize and add more tests for tracking changes to required state #17805

Merged
merged 4 commits into from
Oct 9, 2024
Merged

Sliding Sync: Parameterize and add more tests for tracking changes to required state #17805

merged 4 commits into from
Oct 9, 2024

Conversation

MadLittleMods
Copy link
Contributor

@MadLittleMods MadLittleMods commented Oct 8, 2024 •
edited
Loading

Parameterize and add more tests for tracking changes to required state (_required_state_changes(...))

These are direct modifications to #17785 and should be merged into that PR.

Pull Request Checklist

  • Pull request is based on the develop branch
  • Pull request includes a changelog file. The entry should:
    • Be a short description of your change which makes sense to users. "Fixed a bug that prevented receiving messages from other servers." instead of "Moved X method from EventStore to EventWorkerStore.".
    • Use markdown where necessary, mostly for code blocks.
    • End with either a period (.) or an exclamation mark (!).
    • Start with a capital letter.
    • Feel free to credit yourself, by adding a sentence "Contributed by @github_username." or "Contributed by [Your Name]." to the end of the entry.
  • Code style is correct
    (run the linters)

@MadLittleMods MadLittleMods mentioned this pull request Oct 8, 2024
Merged
@MadLittleMods MadLittleMods marked this pull request as ready for review October 9, 2024 03:08
@MadLittleMods MadLittleMods requested a review from a team as a code owner October 9, 2024 03:08
erikjohnston
erikjohnston approved these changes Oct 9, 2024
View reviewed changes
Copy link
Member

@erikjohnston erikjohnston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@erikjohnston erikjohnston merged commit 596581a into element-hq:erikj/ss_required_state Oct 9, 2024
39 checks passed
@MadLittleMods
Copy link
Contributor Author

Thanks for taking a look @erikjohnston 🐼

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erikjohnston erikjohnston erikjohnston approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MadLittleMods @erikjohnston