Fix a race when registering via email 3pid #16827
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
MatMaul
commented
Jan 18, 2024
| @@ -506,6 +509,23 @@ async def on_POST(self, request: SynapseRequest) -> Tuple[int, JsonDict]: | |||
| "An access token should not be provided on requests to /register (except if type is m.login.application_service)", | |||
| ) | |||
|
|
|||
| # Take a global lock when doing user registration to avoid races, | |||
There was a problem hiding this comment.
I am only protecting normal user registration with the lock because I think _do_appservice_registration and _do_guest_registration are safe but I am not sure to be honest, especially for the appservice one.
Out of safety we may protect the whole code in on_POST, opinions welcome.
MatMaul
force-pushed
the
register-email-3pid-race
branch
3 times, most recently
from
c2cfa8b
to
ea74288
Compare
3 tasks
|
Failing tests should turn to green once #16840 is merged. |
erikjohnston
pushed a commit
that referenced
this pull request
Mar 14, 2024
When a lot of locks are waiting for a single lock, notifying all locks independently with `call_later` on each release is really costly and incurs some kind of async contention, where the CPU is spinning a lot for not much. The included test is taking around 30s before the change, and 0.5s after. It was found following failing tests with #16827.
MatMaul
force-pushed
the
register-email-3pid-race
branch
from
ea74288
to
027b4af
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When hitting the race, 2 different users are created for an unique 3pid email.
Performance impact should be fairly minimal since we usually don't register a new user 10 times per second, unlike sending messages.
Pull Request Checklist
EventStoretoEventWorkerStore.".code blocks.(run the linters)