Skip to content

Commit

Permalink
Update power level default for public rooms (#16907)
Browse files Browse the repository at this point in the history
  • Loading branch information
H-Shay authored Mar 19, 2024
1 parent 8fb5b0f commit cf5adc8
Show file tree
Hide file tree
Showing 3 changed files with 20 additions and 1 deletion.
1 change: 1 addition & 0 deletions changelog.d/16907.misc
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Update power level default for public rooms (#16907).
2 changes: 1 addition & 1 deletion synapse/handlers/room.py
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,7 @@ def __init__(self, hs: "HomeServer"):
"history_visibility": HistoryVisibility.SHARED,
"original_invitees_have_ops": False,
"guest_can_join": False,
"power_level_content_override": {},
"power_level_content_override": {EventTypes.CallInvite: 50},
},
}

Expand Down
18 changes: 18 additions & 0 deletions tests/rest/client/test_rooms.py
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,7 @@ class RoomPermissionsTestCase(RoomBase):
rmcreator_id = "@notme:red"

def prepare(self, reactor: MemoryReactor, clock: Clock, hs: HomeServer) -> None:
self.store_controllers = hs.get_storage_controllers()
self.helper.auth_user_id = self.rmcreator_id
# create some rooms under the name rmcreator_id
self.uncreated_rmid = "!aa:test"
Expand Down Expand Up @@ -482,6 +483,23 @@ def test_member_event_from_ban(self) -> None:
expect_code=HTTPStatus.OK,
)

def test_default_call_invite_power_level(self) -> None:
pl_event = self.get_success(
self.store_controllers.state.get_current_state_event(
self.created_public_rmid, EventTypes.PowerLevels, ""
)
)
assert pl_event is not None
self.assertEqual(50, pl_event.content.get("m.call.invite"))

private_pl_event = self.get_success(
self.store_controllers.state.get_current_state_event(
self.created_rmid, EventTypes.PowerLevels, ""
)
)
assert private_pl_event is not None
self.assertEqual(None, private_pl_event.content.get("m.call.invite"))


class RoomStateTestCase(RoomBase):
"""Tests /rooms/$room_id/state."""
Expand Down

0 comments on commit cf5adc8

Please sign in to comment.