Skip to content
This repository has been archived by the owner on Oct 16, 2024. It is now read-only.

Remove usage of deprecated CryptoEvents #126

Conversation

florianduros
Copy link
Member

@florianduros florianduros commented Oct 7, 2024

Checklist

  • Tests written for new code (and old code if feasible).
  • New or updated public/exported symbols have accurate TSDoc documentation.
  • Linter and other CI checks pass.
  • I have licensed the changes to Element by completing the Contributor License Agreement (CLA)

Task element-hq/element-web#26922

  • Theses deprecated crypto events are not raised by the rust crypto so this is basically dead code.
  • CryptoEvent.WillUpdateDevice is deprecated but still in use in the rust-crypto.The event is replaced by CryptoEvent.DevicesUpdated (they are raised at the same time ) therefore we are merging the behaviour

@florianduros florianduros added this pull request to the merge queue Oct 8, 2024
Merged via the queue into develop with commit 31bd10e Oct 8, 2024
67 of 77 checks passed
@florianduros florianduros deleted the florianduros/rip-out-legacy-crypto/remove-deprecated-crypto-event branch October 8, 2024 08:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T-Task Tasks for the team like planning
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants