Skip to content
This repository has been archived by the owner on Oct 16, 2024. It is now read-only.

Commit

Permalink
Deduplicate media & voip icons using Compound Design Tokens (#129)
Browse files Browse the repository at this point in the history
* Deduplicate media & voip icons using Compound Design Tokens

Signed-off-by: Michael Telatynski <[email protected]>

* Update tests

Signed-off-by: Michael Telatynski <[email protected]>

---------

Signed-off-by: Michael Telatynski <[email protected]>
  • Loading branch information
t3chguy authored Oct 8, 2024
1 parent 197168b commit df4a223
Show file tree
Hide file tree
Showing 49 changed files with 497 additions and 149 deletions.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
16 changes: 6 additions & 10 deletions res/css/views/audio_messages/_PlayPauseButton.pcss
Original file line number Diff line number Diff line change
Expand Up @@ -21,25 +21,21 @@ Please see LICENSE files in the repository root for full details.
background-color: $secondary-content;
mask-repeat: no-repeat;
mask-size: contain;
top: 6px; /* center */
left: 6px; /* center */
width: 20px;
height: 20px;
}

&.mx_PlayPauseButton_disabled::before {
opacity: 0.5;
}

&.mx_PlayPauseButton_play::before {
width: 13px;
height: 16px;
top: 8px; /* center */
left: 12px; /* center */
mask-image: url("$(res)/img/element-icons/play.svg");
mask-image: url("@vector-im/compound-design-tokens/icons/play-solid.svg");
}

&.mx_PlayPauseButton_pause::before {
width: 10px;
height: 12px;
top: 10px; /* center */
left: 11px; /* center */
mask-image: url("$(res)/img/element-icons/pause.svg");
mask-image: url("@vector-im/compound-design-tokens/icons/pause-solid.svg");
}
}
4 changes: 2 additions & 2 deletions res/css/views/messages/_LegacyCallEvent.pcss
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ Please see LICENSE files in the repository root for full details.
&.mx_LegacyCallEvent_rejected,
&.mx_LegacyCallEvent_noAnswer {
.mx_LegacyCallEvent_type_icon::before {
mask-image: url("$(res)/img/voip/declined-video.svg");
mask-image: url("@vector-im/compound-design-tokens/icons/video-call-declined-solid.svg");
}
}
}
Expand All @@ -89,7 +89,7 @@ Please see LICENSE files in the repository root for full details.

&.mx_LegacyCallEvent_video {
.mx_LegacyCallEvent_type_icon::before {
mask-image: url("$(res)/img/voip/missed-video.svg");
mask-image: url("@vector-im/compound-design-tokens/icons/video-call-missed-solid.svg");
}
}
}
Expand Down
2 changes: 1 addition & 1 deletion res/css/views/rooms/_MessageComposer.pcss
Original file line number Diff line number Diff line change
Expand Up @@ -253,7 +253,7 @@ Please see LICENSE files in the repository root for full details.
}

.mx_MessageComposer_voiceMessage::before {
mask-image: url("$(res)/img/element-icons/mic.svg");
mask-image: url("@vector-im/compound-design-tokens/icons/mic-on-solid.svg");
}

.mx_MessageComposer_voiceBroadcast::before {
Expand Down
2 changes: 1 addition & 1 deletion res/css/views/rooms/_ReplyTile.pcss
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ Please see LICENSE files in the repository root for full details.
font: var(--cpd-font-body-md-regular);

&.mx_ReplyTile_audio .mx_MFileBody_info_icon::before {
mask-image: url("$(res)/img/element-icons/speaker.svg");
mask-image: url("@vector-im/compound-design-tokens/icons/volume-on-solid.svg");
}

&.mx_ReplyTile_video .mx_MFileBody_info_icon::before {
Expand Down
12 changes: 6 additions & 6 deletions res/css/views/voip/LegacyCallView/_LegacyCallViewButtons.pcss
Original file line number Diff line number Diff line change
Expand Up @@ -87,19 +87,19 @@ Please see LICENSE files in the repository root for full details.

&.mx_LegacyCallViewButtons_button_mic::before {
height: 20px;
mask-image: url("$(res)/img/element-icons/mic.svg");
mask-image: url("@vector-im/compound-design-tokens/icons/mic-on-solid.svg");
width: 20px;
}

&.mx_LegacyCallViewButtons_button_vid::before {
mask-image: url("$(res)/img/voip/call-view/cam-on.svg");
mask-image: url("@vector-im/compound-design-tokens/icons/video-call-solid.svg");
}

&.mx_LegacyCallViewButtons_button_screensharing {
background-color: $accent;

&::before {
mask-image: url("$(res)/img/voip/call-view/screensharing.svg");
mask-image: url("@vector-im/compound-design-tokens/icons/share-screen-solid.svg");
background-color: white; /* Same on both themes */
}
}
Expand All @@ -118,19 +118,19 @@ Please see LICENSE files in the repository root for full details.

&.mx_LegacyCallViewButtons_button_mic::before {
height: 20px;
mask-image: url("$(res)/img/element-icons/Mic-off.svg");
mask-image: url("@vector-im/compound-design-tokens/icons/mic-off-solid.svg");
width: 20px;
}

&.mx_LegacyCallViewButtons_button_vid::before {
mask-image: url("$(res)/img/voip/call-view/cam-off.svg");
mask-image: url("@vector-im/compound-design-tokens/icons/video-call-off-solid.svg");
}

&.mx_LegacyCallViewButtons_button_screensharing {
background-color: $call-view-button-on-background;

&::before {
mask-image: url("$(res)/img/voip/call-view/screensharing.svg");
mask-image: url("@vector-im/compound-design-tokens/icons/share-screen-solid.svg");
background-color: $call-view-button-on-foreground;
}
}
Expand Down
8 changes: 4 additions & 4 deletions res/css/views/voip/_CallView.pcss
Original file line number Diff line number Diff line change
Expand Up @@ -123,12 +123,12 @@ Please see LICENSE files in the repository root for full details.
}

&.mx_CallView_deviceButton_audio::before {
mask-image: url("$(res)/img/element-icons/mic.svg");
mask-image: url("@vector-im/compound-design-tokens/icons/mic-on-solid.svg");
mask-size: 14px;
}

&.mx_CallView_deviceButton_video::before {
mask-image: url("$(res)/img/voip/call-view/cam-on.svg");
mask-image: url("@vector-im/compound-design-tokens/icons/video-call-solid.svg");
}
}

Expand Down Expand Up @@ -168,12 +168,12 @@ Please see LICENSE files in the repository root for full details.

.mx_CallView_deviceButton {
&.mx_CallView_deviceButton_audio::before {
mask-image: url("$(res)/img/element-icons/Mic-off.svg");
mask-image: url("@vector-im/compound-design-tokens/icons/mic-off-solid.svg");
mask-size: 18px;
}

&.mx_CallView_deviceButton_video::before {
mask-image: url("$(res)/img/voip/call-view/cam-off.svg");
mask-image: url("@vector-im/compound-design-tokens/icons/video-call-off-solid.svg");
}
}
}
Expand Down
4 changes: 2 additions & 2 deletions res/css/views/voip/_VideoFeed.pcss
Original file line number Diff line number Diff line change
Expand Up @@ -72,11 +72,11 @@ Please see LICENSE files in the repository root for full details.
}

&.mx_VideoFeed_mic_muted::before {
mask-image: url("$(res)/img/element-icons/Mic-off.svg");
mask-image: url("@vector-im/compound-design-tokens/icons/mic-off-solid.svg");
}

&.mx_VideoFeed_mic_unmuted::before {
mask-image: url("$(res)/img/element-icons/mic.svg");
mask-image: url("@vector-im/compound-design-tokens/icons/mic-on-solid.svg");
}
}
}
4 changes: 0 additions & 4 deletions res/img/compound/mic-16px.svg

This file was deleted.

4 changes: 0 additions & 4 deletions res/img/compound/pause-12.svg

This file was deleted.

3 changes: 0 additions & 3 deletions res/img/compound/play-16.svg

This file was deleted.

5 changes: 0 additions & 5 deletions res/img/element-icons/Mic-off.svg

This file was deleted.

1 change: 0 additions & 1 deletion res/img/element-icons/mic.svg

This file was deleted.

4 changes: 0 additions & 4 deletions res/img/element-icons/pause.svg

This file was deleted.

3 changes: 0 additions & 3 deletions res/img/element-icons/play.svg
Diff not rendered.
5 changes: 0 additions & 5 deletions res/img/element-icons/speaker.svg
Diff not rendered.
3 changes: 0 additions & 3 deletions res/img/voip/call-view/cam-off.svg
Diff not rendered.
3 changes: 0 additions & 3 deletions res/img/voip/call-view/cam-on.svg
Diff not rendered.
3 changes: 0 additions & 3 deletions res/img/voip/call-view/screensharing.svg
Diff not rendered.
3 changes: 0 additions & 3 deletions res/img/voip/declined-video.svg
Diff not rendered.
3 changes: 0 additions & 3 deletions res/img/voip/missed-video.svg
Diff not rendered.
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,10 @@ import React from "react";
import { Room } from "matrix-js-sdk/src/matrix";
import classNames from "classnames";
import CloseIcon from "@vector-im/compound-design-tokens/assets/web/icons/close";
import MicrophoneIcon from "@vector-im/compound-design-tokens/assets/web/icons/mic-on-solid";

import { LiveBadge, VoiceBroadcastLiveness } from "../..";
import { Icon as LiveIcon } from "../../../../res/img/compound/live-16px.svg";
import { Icon as MicrophoneIcon } from "../../../../res/img/compound/mic-16px.svg";
import { Icon as TimerIcon } from "../../../../res/img/compound/timer-16px.svg";
import { _t } from "../../../languageHandler";
import RoomAvatar from "../../../components/views/avatars/RoomAvatar";
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,9 @@ Please see LICENSE files in the repository root for full details.
*/

import React, { ReactElement } from "react";
import PauseIcon from "@vector-im/compound-design-tokens/assets/web/icons/pause-solid";
import PlayIcon from "@vector-im/compound-design-tokens/assets/web/icons/play-solid";

import { Icon as PlayIcon } from "../../../../res/img/compound/play-16.svg";
import { Icon as PauseIcon } from "../../../../res/img/compound/pause-12.svg";
import { _t } from "../../../languageHandler";
import { VoiceBroadcastControl, VoiceBroadcastPlaybackState } from "../..";

Expand Down
Loading

0 comments on commit df4a223

Please sign in to comment.