Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dual license: AGPL + Element Commercial #3401

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

manuroe
Copy link
Member

@manuroe manuroe commented Oct 11, 2024

Make it clear that the code is dual licensed.
Note there is a new LICENSE-COMMERCIAL file.

Copy link

github-actions bot commented Oct 11, 2024

Warnings
⚠️ This pull request seems relatively large. Please consider splitting it into multiple smaller ones.
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against 029821c

Copy link

codecov bot commented Oct 11, 2024

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
840 1 839 0
View the full list of 1 ❄️ flaky tests
PreviewTests test_loginScreen()

Flake rate in main: 26.78% (Passed 134 times, Failed 49 times)

Stack Traces | 4.03s run time
failed - Snapshot "matrix.org" does not match reference.

@−
"file:.../__Snapshots__/PreviewTests/test_loginScreen-iPhone-16-en-GB.matrix-org.png"
@+
"file:.../tmp/PreviewTests/test_loginScreen-iPhone-16-en-GB.matrix-org.png"

To configure output for a custom diff tool, use 'withSnapshotTesting'. For example:

    withSnapshotTesting(diffTool: .ksdiff) {
      // ...
    }

The percentage of pixels that match 0.8511963 is less than required 1.0
The lowest perceptual color precision 0.39937502 is less than required 0.98 (.../PreviewTests/Sources/PreviewTests.swift:84)

To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard

@manuroe manuroe added the pr-misc for other changes label Oct 11, 2024
@manuroe
Copy link
Member Author

manuroe commented Oct 11, 2024

This PR is draft until we get a confirmation from legals.

Copy link

sonarcloud bot commented Oct 11, 2024

@manuroe
Copy link
Member Author

manuroe commented Oct 11, 2024

This is all good. The PR can be reviewed.

@manuroe manuroe marked this pull request as ready for review October 11, 2024 15:27
@manuroe manuroe requested a review from a team as a code owner October 11, 2024 15:27
@manuroe manuroe requested review from Velin92 and stefanceriu and removed request for a team and Velin92 October 11, 2024 15:27
Copy link
Member

@Velin92 Velin92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@manuroe LGTM however I think we should also update the README to include a link and a reference to the commercial license

@stefanceriu stefanceriu removed their request for review October 16, 2024 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-misc for other changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants