Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the secondary button stroke colour. #3393

Merged
merged 2 commits into from
Oct 10, 2024
Merged

Update the secondary button stroke colour. #3393

merged 2 commits into from
Oct 10, 2024

Conversation

pixlwave
Copy link
Member

@pixlwave pixlwave commented Oct 10, 2024 •
edited
Loading

This PR updates Compound to include element-hq/compound-ios#110 which fixes our secondary button style to match Figma properly.

@pixlwave pixlwave requested a review from a team as a code owner October 10, 2024 10:42
@pixlwave pixlwave requested review from Velin92 and removed request for a team October 10, 2024 10:42
@pixlwave pixlwave added the pr-change for updates to an existing feature label Oct 10, 2024
@github-actions GitHub Actions
Copy link

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.

Generated by 🚫 Danger Swift against 4114e26

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 10, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@codecov Codecov
Copy link

codecov bot commented Oct 10, 2024 •
edited
Loading

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
840 1 839 0
View the top 1 failed tests by shortest run time 
RoomRolesAndPermissionsScreenViewModelTests testResetPermissions()
Stack Traces | 11.4s run time 
XCTAssertTrue failed (.../UnitTests/Sources/RoomRolesAndPermissionsScreenViewModelTests.swift:42)

To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard

@pixlwave pixlwave merged commit 13bc3a1 into develop Oct 10, 2024
13 checks passed
@pixlwave pixlwave deleted the doug/secondary-button-style branch October 10, 2024 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Velin92 Velin92 Velin92 approved these changes

Assignees
No one assigned
Labels
pr-change for updates to an existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pixlwave @Velin92