Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show the Login with QR Code button. #3392

Merged
merged 1 commit into from
Oct 10, 2024

Conversation

pixlwave
Copy link
Member

Part of element-hq/element-meta#2558 (no local task yet), opening this so it's ready if we decide to go ahead with this now.

@pixlwave pixlwave requested a review from a team as a code owner October 10, 2024 09:34
@pixlwave pixlwave requested review from Velin92 and removed request for a team October 10, 2024 09:34
Copy link

github-actions bot commented Oct 10, 2024

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.

Generated by 🚫 Danger Swift against e70083a

@pixlwave pixlwave added the pr-feature for a new feature label Oct 10, 2024
Copy link

sonarcloud bot commented Oct 10, 2024

Copy link

codecov bot commented Oct 10, 2024

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
840 1 839 0
View the full list of 1 ❄️ flaky tests
PreviewTests test_roomMemberDetailsScreen()

Flake rate in main: 16.50% (Passed 248 times, Failed 49 times)

Stack Traces | 2.6s run time
failed - Snapshot "Other User" does not match reference.

@−
"file:.../__Snapshots__/PreviewTests/test_roomMemberDetailsScreen-iPhone-16-pseudo.Other-User.png"
@+
"file:.../tmp/PreviewTests/test_roomMemberDetailsScreen-iPhone-16-pseudo.Other-User.png"

To configure output for a custom diff tool, use 'withSnapshotTesting'. For example:

    withSnapshotTesting(diffTool: .ksdiff) {
      // ...
    }

The percentage of pixels that match 0.8474121 is less than required 1.0
The lowest perceptual color precision 0.148125 is less than required 0.98 (.../PreviewTests/Sources/PreviewTests.swift:84)

To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard

@pixlwave pixlwave merged commit 8e03cc8 into develop Oct 10, 2024
9 checks passed
@pixlwave pixlwave deleted the doug/show-login-with-qr-code-button branch October 10, 2024 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-feature for a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants