Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display a warning when a user's pinned identity changes #3368

Merged
merged 1 commit into from
Oct 7, 2024

Conversation

stefanceriu
Copy link
Member

@stefanceriu stefanceriu commented Oct 4, 2024

As per element-hq/element-meta#2544

Using matrix-org/matrix-rust-sdk#4022 and matrix-org/matrix-rust-sdk#4068

Simulator.Screen.Recording.-.iPhone.16.-.2024-10-04.at.13.11.52.mp4

@stefanceriu stefanceriu added the pr-feature for a new feature label Oct 4, 2024
@stefanceriu stefanceriu requested a review from a team as a code owner October 4, 2024 10:29
@stefanceriu stefanceriu requested review from Velin92 and removed request for a team October 4, 2024 10:29
Copy link

github-actions bot commented Oct 4, 2024

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against fb21b17

Copy link

codecov bot commented Oct 4, 2024

Codecov Report

Attention: Patch coverage is 75.71429% with 51 lines in your changes missing coverage. Please review.

Project coverage is 77.56%. Comparing base (e6f4dd3) to head (fb21b17).
Report is 4 commits behind head on develop.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...urces/Screens/RoomScreen/RoomScreenViewModel.swift 45.58% 37 Missing ⚠️
...X/Sources/Screens/RoomScreen/View/RoomScreen.swift 71.42% 6 Missing ⚠️
...rces/Services/ElementCall/ElementCallService.swift 0.00% 3 Missing ⚠️
...Screens/RoomScreen/View/RoomScreenFooterView.swift 96.49% 2 Missing ⚠️
...e/TimelineItemContent/EncryptionAuthenticity.swift 60.00% 2 Missing ⚠️
...ces/Screens/RoomScreen/RoomScreenCoordinator.swift 83.33% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3368      +/-   ##
===========================================
+ Coverage    77.21%   77.56%   +0.34%     
===========================================
  Files          739      740       +1     
  Lines        59962    60193     +231     
===========================================
+ Hits         46302    46689     +387     
+ Misses       13660    13504     -156     
Flag Coverage Δ
unittests 68.98% <75.71%> (+0.12%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@Velin92 Velin92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but there is one thing that needs to be changed

Copy link
Member

@Velin92 Velin92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stefanceriu stefanceriu force-pushed the stefan/identityStatusChanges branch 2 times, most recently from 036a95c to 91562db Compare October 7, 2024 16:25
Copy link

sonarcloud bot commented Oct 7, 2024

@stefanceriu stefanceriu merged commit 794d0ee into develop Oct 7, 2024
11 checks passed
@stefanceriu stefanceriu deleted the stefan/identityStatusChanges branch October 7, 2024 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-feature for a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants