Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide timeline media preparation #3361

Merged
merged 2 commits into from
Oct 3, 2024
Merged

Conversation

pixlwave
Copy link
Member

@pixlwave pixlwave commented Oct 2, 2024

Cherry picking a couple of commits in preparation for #3228 that aren't specifically related to the changes:

  • Use the new @Entry macro for Environment values.
  • MockMediaProviderMediaProviderMock using Sourcery.

@pixlwave pixlwave requested a review from a team as a code owner October 2, 2024 16:46
@pixlwave pixlwave requested review from Velin92 and removed request for a team October 2, 2024 16:46
Copy link

github-actions bot commented Oct 2, 2024

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against 4c3218a

@pixlwave pixlwave force-pushed the doug/hide-timeline-media-prep branch from 92c4577 to 4c3218a Compare October 2, 2024 16:49
@pixlwave pixlwave added the pr-misc for other changes label Oct 2, 2024
Copy link

sonarcloud bot commented Oct 2, 2024

Copy link

codecov bot commented Oct 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.53%. Comparing base (e0ee4be) to head (4c3218a).
Report is 2 commits behind head on develop.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3361      +/-   ##
===========================================
+ Coverage    77.49%   77.53%   +0.03%     
===========================================
  Files          740      739       -1     
  Lines        59824    59814      -10     
===========================================
+ Hits         46363    46378      +15     
+ Misses       13461    13436      -25     
Flag Coverage Δ
unittests 68.94% <100.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pixlwave pixlwave merged commit 5522871 into develop Oct 3, 2024
13 checks passed
@pixlwave pixlwave deleted the doug/hide-timeline-media-prep branch October 3, 2024 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-misc for other changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants