Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crypto: Configure decryption trustRequirement based on config flag #3358

Merged

Conversation

BillCarsonFr
Copy link
Member

Pull Request Checklist

Depends on matrix-org/matrix-rust-sdk#4046

Part of https://github.com/element-hq/crypto-internal/issues/354

For now the new decryption errors will show as regular ones (waiting for this message), a following PR will fix that once the sdk has support for different UTD errors

UI changes have been tested with:

  • iPhone and iPad simulators in portrait and landscape orientations.
  • Dark mode enabled and disabled.
  • Various sizes of dynamic type.
  • Voiceover enabled.

@BillCarsonFr BillCarsonFr added the pr-feature for a new feature label Oct 2, 2024
Copy link

github-actions bot commented Oct 2, 2024

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
⚠️ Please add a sign-off to either the PR description or to the commits themselves.
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against 054a871

Copy link

codecov bot commented Oct 2, 2024

❌ 2 Tests Failed:

Tests completed Failed Passed Skipped
840 2 838 0
View the full list of 2 ❄️ flaky tests
PreviewTests test_loginScreen()

Flake rate in main: 30.69% (Passed 70 times, Failed 31 times)

Stack Traces | 4.34s run time
failed - Snapshot "matrix.org" does not match reference.

@−
"file:.../__Snapshots__/PreviewTests/test_loginScreen-iPhone-16-pseudo.matrix-org.png"
@+
"file:.../tmp/PreviewTests/test_loginScreen-iPhone-16-pseudo.matrix-org.png"

To configure output for a custom diff tool, use 'withSnapshotTesting'. For example:

    withSnapshotTesting(diffTool: .ksdiff) {
      // ...
    }

The percentage of pixels that match 0.8482666 is less than required 1.0
The lowest perceptual color precision 0.39937502 is less than required 0.98 (.../PreviewTests/Sources/PreviewTests.swift:84)
RoomScreenViewModelTests testPinnedEventsBanner()

Flake rate in main: 26.32% (Passed 98 times, Failed 35 times)

Stack Traces | 12.1s run time
Asynchronous wait failed: Exceeded timeout of 10 seconds, with unfulfilled expectations: "Awaiting publisher". (.../Sources/Extensions/XCTestCase.swift:43)

To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard

@BillCarsonFr BillCarsonFr force-pushed the valere/crypto_only_signed_decryption_trust_req branch from 161c2a3 to e8edf7f Compare October 3, 2024 07:13
@BillCarsonFr BillCarsonFr force-pushed the valere/crypto_only_signed_decryption_trust_req branch 2 times, most recently from a3ff9ac to 7fe15b6 Compare October 8, 2024 09:48
@BillCarsonFr BillCarsonFr marked this pull request as ready for review October 8, 2024 09:48
@BillCarsonFr BillCarsonFr requested a review from a team as a code owner October 8, 2024 09:48
@BillCarsonFr BillCarsonFr requested review from pixlwave and removed request for a team October 8, 2024 09:48
Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a small syntax nit included inline.

ElementX/Sources/Other/Extensions/ClientBuilder.swift Outdated Show resolved Hide resolved
ElementX/Sources/Other/Extensions/ClientBuilder.swift Outdated Show resolved Hide resolved
@BillCarsonFr BillCarsonFr force-pushed the valere/crypto_only_signed_decryption_trust_req branch from 34025df to 054a871 Compare October 8, 2024 13:44
Copy link

sonarcloud bot commented Oct 8, 2024

@BillCarsonFr BillCarsonFr enabled auto-merge (squash) October 8, 2024 14:00
@BillCarsonFr BillCarsonFr merged commit cf81072 into develop Oct 8, 2024
7 checks passed
@BillCarsonFr BillCarsonFr deleted the valere/crypto_only_signed_decryption_trust_req branch October 8, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-feature for a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants