Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add detection for latest devices. #3327

Merged
merged 4 commits into from
Sep 25, 2024
Merged

Conversation

pixlwave
Copy link
Member

@pixlwave pixlwave commented Sep 24, 2024

The main update is for DeviceKit which now detects iPad Pro (M4), iPad Air (M2) and iPhones 16.

Additionally updates other packages including changing KZFileWatchers to use a release now that there's a tag against the commit we needed to use.

Notable changes:
- DeviceKit now detects iPad Pro (M4), iPad Air (M2) and iPhones 16.
- KZFileWatchers isn't updated but now has a tag to pin to.
@pixlwave pixlwave requested a review from a team as a code owner September 24, 2024 16:37
@pixlwave pixlwave requested review from stefanceriu and removed request for a team September 24, 2024 16:38
Copy link

github-actions bot commented Sep 24, 2024

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.

Generated by 🚫 Danger Swift against c9f76c5

@pixlwave pixlwave added the pr-change for updates to an existing feature label Sep 24, 2024
Try fix an issue where CI isn't finding iPhone 16 when its clearly listed by simctl.
Copy link

codecov bot commented Sep 24, 2024

❌ 2 Tests Failed:

Tests completed Failed Passed Skipped
824 2 822 0
View the full list of 2 ❄️ flaky tests
PreviewTests test_userProfileScreen()

Flake rate in main: 26.32% (Passed 14 times, Failed 5 times)

Stack Traces | 8.86s run time
failed - Snapshot "Other User" does not match reference.

@−
"file:.../__Snapshots__/PreviewTests/test_userProfileScreen-iPhone-16-en-GB.Other-User.png"
@+
"file:.../tmp/PreviewTests/test_userProfileScreen-iPhone-16-en-GB.Other-User.png"

To configure output for a custom diff tool, use 'withSnapshotTesting'. For example:

    withSnapshotTesting(diffTool: .ksdiff) {
      // ...
    }

The percentage of pixels that match 0.9088135 is less than required 1.0
The lowest perceptual color precision 0.31062502 is less than required 0.98 (.../PreviewTests/Sources/PreviewTests.swift:66)
RoomScreenViewModelTests testRoomInfoUpdate()

Flake rate in main: 9.09% (Passed 10 times, Failed 1 times)

Stack Traces | 31.2s run time
Asynchronous wait failed: Exceeded timeout of 10 seconds, with unfulfilled expectations: "Awaiting publisher". (.../Sources/Extensions/XCTestCase.swift:43)

To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard

Copy link

sonarcloud bot commented Sep 25, 2024

@pixlwave pixlwave merged commit 6faa26e into develop Sep 25, 2024
6 of 7 checks passed
@pixlwave pixlwave deleted the doug/iphone-16-device-kit branch September 25, 2024 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-change for updates to an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants