-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace Prefire with a very similar but simpler and more direct approach #3232
Conversation
…t, mirrors UITests)
Generated by 🚫 Danger Swift against 1ebf8bc |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3232 +/- ##
===========================================
- Coverage 54.43% 53.78% -0.66%
===========================================
Files 723 725 +2
Lines 53926 54565 +639
===========================================
- Hits 29355 29348 -7
- Misses 24571 25217 +646
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice! 👏
.gitattributes
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Asking a question right at the start of the review so I haven't seen any code, but how come these moved?
ElementX/SupportingFiles/Settings.bundle/Acknowledgements.plist
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be really nice now if we could separate out the generated code from assertSnapshots(matching: preview)
and everything it calls.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will do that as the next step, separating everything in a differnet repo to be used by compound as well
Quality Gate passedIssues Measures |
I think we still need to: