Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #3050 - Sync mute state between ElementCall and CallKit #3120

Merged
merged 1 commit into from
Aug 6, 2024

Conversation

stefanceriu
Copy link
Member

@stefanceriu stefanceriu commented Aug 6, 2024

  • listen to changes in the mute state and sync up the CallKit controls with ElementCall and back
  • rewrite how we construct and pass custom messages between the ElementCall widget and the widget driver
callkit.mov

@stefanceriu stefanceriu requested a review from a team as a code owner August 6, 2024 10:25
@stefanceriu stefanceriu requested review from Velin92 and removed request for a team August 6, 2024 10:25
Copy link

codecov bot commented Aug 6, 2024

Codecov Report

Attention: Patch coverage is 0% with 67 lines in your changes missing coverage. Please review.

Project coverage is 77.45%. Comparing base (cdaa88e) to head (1f68fe5).
Report is 4 commits behind head on develop.

Files Patch % Lines
...urces/Screens/CallScreen/CallScreenViewModel.swift 0.00% 37 Missing ⚠️
...Services/ElementCall/ElementCallWidgetDriver.swift 0.00% 21 Missing ⚠️
...rces/Services/ElementCall/ElementCallService.swift 0.00% 8 Missing ⚠️
ElementX/Sources/Application/AppCoordinator.swift 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3120      +/-   ##
===========================================
- Coverage    77.80%   77.45%   -0.35%     
===========================================
  Files          713      714       +1     
  Lines        54994    55786     +792     
===========================================
+ Hits         42786    43211     +425     
- Misses       12208    12575     +367     
Flag Coverage Δ
unittests 68.24% <0.00%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@Velin92 Velin92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a small suggestion, the rest LGTM

@stefanceriu stefanceriu force-pushed the stefan/elementCallMutePassthrough branch from b06ff30 to 1f68fe5 Compare August 6, 2024 10:59
Copy link

sonarcloud bot commented Aug 6, 2024

@stefanceriu stefanceriu added the pr-feature for a new feature label Aug 6, 2024
@stefanceriu stefanceriu merged commit d31e128 into develop Aug 6, 2024
11 of 12 checks passed
@stefanceriu stefanceriu deleted the stefan/elementCallMutePassthrough branch August 6, 2024 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-feature for a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants