Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Encryption Authenticity explanations. #3116

Merged
merged 1 commit into from
Aug 6, 2024

Conversation

pixlwave
Copy link
Member

@pixlwave pixlwave commented Aug 5, 2024

This PR makes the following changes:

  • Tapping on the status icon in the SendInfo label shows an alert with a description of the status.
  • Shows a message's authenticity warning in its action menu.
  • Tidy up VoiceOver slightly in the room list and timeline item menu.

Closes #3109

Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-08-01.at.16.42.47.mp4

@pixlwave pixlwave requested a review from a team as a code owner August 5, 2024 15:32
@pixlwave pixlwave requested review from stefanceriu and removed request for a team August 5, 2024 15:32
@pixlwave pixlwave force-pushed the doug/authenticity-interaction branch from cccd6b8 to 7630c10 Compare August 5, 2024 15:32
Copy link

github-actions bot commented Aug 5, 2024

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against a96a55d

@pixlwave pixlwave added the pr-wip for anything that isn't ready to ship and will be enabled at a later date label Aug 5, 2024
Copy link

codecov bot commented Aug 5, 2024

Codecov Report

Attention: Patch coverage is 81.41026% with 29 lines in your changes missing coverage. Please review.

Project coverage is 77.71%. Comparing base (ff2c42d) to head (a96a55d).
Report is 1 commits behind head on develop.

Files Patch % Lines
...urces/Screens/RoomScreen/RoomScreenViewModel.swift 3.84% 25 Missing ⚠️
...mScreen/View/Style/TimelineItemSendInfoLabel.swift 91.17% 3 Missing ⚠️
...ns/RoomScreen/View/ItemMenu/TimelineItemMenu.swift 98.48% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3116      +/-   ##
===========================================
+ Coverage    77.69%   77.71%   +0.02%     
===========================================
  Files          714      714              
  Lines        55246    55363     +117     
===========================================
+ Hits         42922    43025     +103     
- Misses       12324    12338      +14     
Flag Coverage Δ
unittests 68.30% <81.41%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pixlwave pixlwave force-pushed the doug/authenticity-interaction branch from 7630c10 to 5de4470 Compare August 5, 2024 16:39
@@ -169,23 +179,54 @@ struct TimelineItemMenu: View {
}
}

private extension EncryptionAuthenticity {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not a big fan of having Colors encoded into the EncryptionAuthenticity. Wouldn't it be better if we would use the Compound approach and replace enum Color { case red, gray } with an enum Importance { case primary, secondary } or similar?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, I now understand that this has been done this way to keep in line with the Rust implementation.

For posterity though, we belive colors to be inherently localisable and severity to be a way better abstraction.

Otherwise we can find ourselves in weird situations in which colors don't mean what we expect them to e.g. In China, red is auspicious—associated with life-generating energy (the sun, blood, and fire)—and is the color of celebrations and prosperity

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For context this is on purpose, and we want consistency across clients on how crypto shields/warning are represented(idealy same icons, colors, text).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand, just pointing out that doesn't seem to be a winning approach seeing as how both icons and colors need to also be localized for the various cultures matrix/element will be used in.

Another random example:
UX designers need to take into account cultural differences when selecting symbols and colors. For example, while the color green is associated with life and growth in many Western cultures, it symbolizes death in some Asian countries

Copy link

sonarcloud bot commented Aug 6, 2024

@pixlwave pixlwave merged commit e667be0 into develop Aug 6, 2024
10 checks passed
@pixlwave pixlwave deleted the doug/authenticity-interaction branch August 6, 2024 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-wip for anything that isn't ready to ship and will be enabled at a later date
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task] Display message shield explanation
3 participants