-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor voice messages touch interaction #1970
Conversation
Generated by 🚫 Danger Swift against 7f3ffed |
📱 Scan the QR code below to install the build for this PR. If you can't scan the QR code you can install the build via this link: https://i.diawi.com/NLUkeb |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #1970 +/- ##
===========================================
+ Coverage 69.05% 69.07% +0.02%
===========================================
Files 516 517 +1
Lines 35347 35319 -28
Branches 17184 17147 -37
===========================================
- Hits 24408 24398 -10
+ Misses 10300 10285 -15
+ Partials 639 636 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
This all works well, thanks for making the changes. One small request - can you turn off the haptic on scrubbing? I want to add haptics in the next version, but not when the user is scrubbing through a voice message |
Sure, consider it done! 👍🏻 |
b4d6ce9
to
de881d5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me 👍
...vices/Timeline/TimelineItems/Items/Messages/VoiceMessages/VoiceMessageRoomPlaybackView.swift
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, it's definitely better to have the vertical scrolling working 👍
a960974
to
7f3ffed
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
This PR enhance the touch interaction with voice messages:
Result
int-demo.mp4