Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor voice messages touch interaction #1970

Merged
merged 18 commits into from
Oct 27, 2023

Conversation

alfogrillo
Copy link
Contributor

@alfogrillo alfogrillo commented Oct 26, 2023

This PR enhance the touch interaction with voice messages:

  • User can tap on the waveform directly to seek
  • User can drag the cursor to seek
  • Vertical scroll in the timeline and swipe to reply work nicely

Result

int-demo.mp4

@alfogrillo alfogrillo added the Trigger-PR-Build Uses to trigger alpha builds for PRs label Oct 26, 2023
@github-actions
Copy link

github-actions bot commented Oct 26, 2023

Warnings
⚠️ Please add a changelog.
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
⚠️ You seem to have made changes to views. Please consider adding screenshots.
⚠️

ElementX/Sources/Screens/RoomScreen/RoomScreenViewModel.swift#L352 - Arguments can be omitted when matching enums with associated values if they are not used. (empty_enum_arguments)

⚠️

ElementX/Sources/Screens/RoomScreen/RoomScreenViewModel.swift#L1086 - File should contain 1000 lines or less: currently contains 1086 (file_length)

Generated by 🚫 Danger Swift against 7f3ffed

@github-actions
Copy link

github-actions bot commented Oct 26, 2023

📱 Scan the QR code below to install the build for this PR.
🔒 This build is for internal testing purpose. Only devices listed in the ad-hoc provisioning profile can install Element Alpha.

QR code

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/NLUkeb

@codecov
Copy link

codecov bot commented Oct 26, 2023

Codecov Report

Attention: 21 lines in your changes are missing coverage. Please review.

Comparison is base (2eb8945) 69.05% compared to head (a960974) 69.07%.
Report is 1 commits behind head on develop.

❗ Current head a960974 differs from pull request most recent head 7f3ffed. Consider uploading reports for the commit 7f3ffed to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1970      +/-   ##
===========================================
+ Coverage    69.05%   69.07%   +0.02%     
===========================================
  Files          516      517       +1     
  Lines        35347    35319      -28     
  Branches     17184    17147      -37     
===========================================
- Hits         24408    24398      -10     
+ Misses       10300    10285      -15     
+ Partials       639      636       -3     
Flag Coverage Δ
unittests 54.31% <72.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...ources/Other/Progress/ProgressCursorModifier.swift 100.00% <100.00%> (ø)
...Screens/ComposerToolbar/View/ComposerToolbar.swift 76.57% <100.00%> (ø)
...oserToolbar/View/VoiceMessagePreviewComposer.swift 70.32% <100.00%> (+7.82%) ⬆️
.../Sources/Screens/RoomScreen/RoomScreenModels.swift 71.79% <ø> (ø)
...urces/Screens/RoomScreen/RoomScreenViewModel.swift 49.40% <ø> (+0.05%) ⬆️
.../RoomScreen/View/Style/LongPressWithFeedback.swift 83.33% <100.00%> (+2.08%) ⬆️
...s/VoiceMessages/VoiceMessageRoomTimelineView.swift 53.33% <ø> (+2.26%) ⬆️
...een/View/Style/TimelineItemBubbledStylerView.swift 96.39% <0.00%> (-0.22%) ⬇️
...creen/View/Style/TimelineItemPlainStylerView.swift 92.05% <0.00%> (ø)
...s/VoiceMessages/VoiceMessageRoomPlaybackView.swift 74.02% <63.63%> (+25.30%) ⬆️
... and 1 more

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alfogrillo alfogrillo marked this pull request as ready for review October 27, 2023 06:51
@alfogrillo alfogrillo requested a review from a team as a code owner October 27, 2023 06:51
@alfogrillo alfogrillo requested review from pixlwave and nimau and removed request for a team October 27, 2023 06:51
@callumu
Copy link

callumu commented Oct 27, 2023

This all works well, thanks for making the changes.

One small request - can you turn off the haptic on scrubbing? I want to add haptics in the next version, but not when the user is scrubbing through a voice message

@alfogrillo
Copy link
Contributor Author

This all works well, thanks for making the changes.

One small request - can you turn off the haptic on scrubbing? I want to add haptics in the next version, but not when the user is scrubbing through a voice message

Sure, consider it done! 👍🏻

@alfogrillo alfogrillo force-pushed the alfogrillo/voice-messages-interaction branch from b4d6ce9 to de881d5 Compare October 27, 2023 08:01
Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me 👍

Copy link
Contributor

@nimau nimau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, it's definitely better to have the vertical scrolling working 👍

@alfogrillo alfogrillo force-pushed the alfogrillo/voice-messages-interaction branch from a960974 to 7f3ffed Compare October 27, 2023 09:27
Copy link
Contributor

@nimau nimau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarcloud
Copy link

sonarcloud bot commented Oct 27, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
1.8% 1.8% Duplication

@alfogrillo alfogrillo enabled auto-merge (squash) October 27, 2023 09:30
@alfogrillo alfogrillo merged commit adfe855 into develop Oct 27, 2023
6 checks passed
@alfogrillo alfogrillo deleted the alfogrillo/voice-messages-interaction branch October 27, 2023 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Trigger-PR-Build Uses to trigger alpha builds for PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants