-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Keep the progress indicator visible after pausing or scrubbing. #1969
Conversation
Generated by 🚫 Danger Swift against b05662c |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #1969 +/- ##
===========================================
- Coverage 68.98% 68.87% -0.11%
===========================================
Files 517 517
Lines 35508 35546 +38
Branches 17241 17259 +18
===========================================
- Hits 24496 24484 -12
- Misses 10366 10418 +52
+ Partials 646 644 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
c4e30f5
to
cd6b410
Compare
ElementX/Sources/Screens/ComposerToolbar/View/ComposerToolbar.swift
Outdated
Show resolved
Hide resolved
ElementX/Sources/Screens/ComposerToolbar/View/ComposerToolbar.swift
Outdated
Show resolved
Hide resolved
ElementX/Sources/Screens/ComposerToolbar/ComposerToolbarModels.swift
Outdated
Show resolved
Hide resolved
ElementX/Sources/Screens/ComposerToolbar/ComposerToolbarModels.swift
Outdated
Show resolved
Hide resolved
Also stop playback when scrubbing another voice message.
d3b40ae
to
b05662c
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
This PR changes the criteria for displaying the progress indicator.
The progress indicator is now displayed when an audio player is attached to the voice message view or when a scrub is performed.
When a scrub is performed on a voice message other than the one currently playing, playback is stopped and the audio player is detached.
In this way, the progress indicator disappears when it is displayed in another view, preventing multiple progress indicators from being displayed at the same time.