Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Keep the progress indicator visible after pausing or scrubbing. #1969

Merged
merged 5 commits into from
Oct 27, 2023

Conversation

nimau
Copy link
Contributor

@nimau nimau commented Oct 26, 2023

This PR changes the criteria for displaying the progress indicator.

The progress indicator is now displayed when an audio player is attached to the voice message view or when a scrub is performed.
When a scrub is performed on a voice message other than the one currently playing, playback is stopped and the audio player is detached.

In this way, the progress indicator disappears when it is displayed in another view, preventing multiple progress indicators from being displayed at the same time.

@nimau nimau requested a review from a team as a code owner October 26, 2023 16:13
@nimau nimau requested review from Velin92 and removed request for a team October 26, 2023 16:13
@github-actions
Copy link

github-actions bot commented Oct 26, 2023

Warnings
⚠️ Please add a changelog.
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
⚠️ You seem to have made changes to views. Please consider adding screenshots.
⚠️

ElementX/Sources/Screens/RoomScreen/RoomScreenViewModel.swift#L1105 - File should contain 1000 lines or less: currently contains 1105 (file_length)

Generated by 🚫 Danger Swift against b05662c

@codecov
Copy link

codecov bot commented Oct 26, 2023

Codecov Report

Attention: 21 lines in your changes are missing coverage. Please review.

Comparison is base (0b31446) 68.98% compared to head (cd6b410) 68.87%.

❗ Current head cd6b410 differs from pull request most recent head b05662c. Consider uploading reports for the commit b05662c to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1969      +/-   ##
===========================================
- Coverage    68.98%   68.87%   -0.11%     
===========================================
  Files          517      517              
  Lines        35508    35546      +38     
  Branches     17241    17259      +18     
===========================================
- Hits         24496    24484      -12     
- Misses       10366    10418      +52     
+ Partials       646      644       -2     
Flag Coverage Δ
unittests 54.29% <51.16%> (-0.14%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...urces/Services/Audio/Player/AudioPlayerState.swift 96.55% <100.00%> (+1.40%) ⬆️
...s/VoiceMessages/VoiceMessageRoomPlaybackView.swift 72.97% <100.00%> (-1.06%) ⬇️
...s/Services/VoiceMessage/VoiceMessageRecorder.swift 80.82% <100.00%> (+0.13%) ⬆️
...urces/Screens/RoomScreen/RoomScreenViewModel.swift 49.35% <50.00%> (-0.06%) ⬇️
...ne/TimelineController/RoomTimelineController.swift 39.73% <0.00%> (-0.09%) ⬇️
...her/VoiceMessage/WaveformInteractionModifier.swift 67.64% <40.00%> (ø)
...oserToolbar/View/VoiceMessagePreviewComposer.swift 68.13% <40.00%> (-2.20%) ⬇️
...Screens/ComposerToolbar/View/ComposerToolbar.swift 73.05% <0.00%> (-1.60%) ⬇️

... and 11 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@alfogrillo alfogrillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nimau nimau force-pushed the nicolas/voice-message-scrub-cursor-visibility branch 2 times, most recently from c4e30f5 to cd6b410 Compare October 27, 2023 13:43
@nimau nimau force-pushed the nicolas/voice-message-scrub-cursor-visibility branch from d3b40ae to b05662c Compare October 27, 2023 15:02
@sonarcloud
Copy link

sonarcloud bot commented Oct 27, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@nimau nimau enabled auto-merge (squash) October 27, 2023 15:03
@nimau nimau merged commit a32a7c8 into develop Oct 27, 2023
6 checks passed
@nimau nimau deleted the nicolas/voice-message-scrub-cursor-visibility branch October 27, 2023 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants