Add support for Face ID/Touch ID to app lock. #1966

pixlwave · 2023-10-26T11:55:02Z

Adds biometric unlock support to the AppLock feature. Should be testable now, although there are still some edge cases I need to handle in follow-up PRs.

Enabling with PIN code already setup (for illustration, the grace period is turned off):

RPReplay_Final1698326404.MP4

github-actions · 2023-10-26T11:56:30Z

	Warnings
⚠️	Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
⚠️	You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against de5b7e7

ElementX/Resources/Localizations/en.lproj/Untranslated.strings

github-actions · 2023-10-26T12:08:51Z

📱 Scan the QR code below to install the build for this PR.
🔒 This build is for internal testing purpose. Only devices listed in the ad-hoc provisioning profile can install Element Alpha.

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/icugnu

codecov · 2023-10-26T15:10:49Z

Codecov Report

Attention: 95 lines in your changes are missing coverage. Please review.

Comparison is base (2eb8945) 69.05% compared to head (3cbd279) 68.87%.

❗ Current head 3cbd279 differs from pull request most recent head de5b7e7. Consider uploading reports for the commit de5b7e7 to get more accurate results

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #1966      +/-   ##
===========================================
- Coverage    69.05%   68.87%   -0.18%     
===========================================
  Files          516      516              
  Lines        35347    35465     +118     
  Branches     17184    17225      +41     
===========================================
+ Hits         24408    24428      +20     
- Misses       10300    10391      +91     
- Partials       639      646       +7

Flag	Coverage Δ
unittests	`54.16% <50.00%> (-0.18%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
ElementX/Sources/Application/AppSettings.swift	`96.82% <ø> (ø)`
...AppLock/AppLockScreen/AppLockScreenViewModel.swift	`94.33% <100.00%> (+0.33%)`	⬆️
...tingsScreen/AppLockSetupSettingsScreenModels.swift	`100.00% <100.00%> (ø)`
...ttingsScreen/View/AppLockSetupSettingsScreen.swift	`90.69% <100.00%> (ø)`
...rces/Services/AppLock/AppLockServiceProtocol.swift	`90.00% <ø> (-0.91%)`	⬇️
...ementX/Sources/Services/AppLock/AppLockTimer.swift	`100.00% <100.00%> (ø)`
ElementX/Sources/Application/AppCoordinator.swift	`54.75% <0.00%> (-0.08%)`	⬇️
...FlowCoordinators/AppLockSetupFlowCoordinator.swift	`34.26% <0.00%> (-0.39%)`	⬇️
...ources/Screens/AppLock/Common/LABiometryType.swift	`81.25% <0.00%> (ø)`
...Screen/AppLockSetupBiometricsScreenViewModel.swift	`84.61% <73.91%> (-1.75%)`	⬇️
... and 4 more