Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: always detach voice message audio player state before playing #1965

Merged
merged 1 commit into from
Oct 26, 2023

Conversation

nimau
Copy link
Contributor

@nimau nimau commented Oct 26, 2023

This PR fixes an issue when two voice message events are forwarded to the same room.
In this case, both events have the same mxc:// content and the timeline items were not correctly detached from the audio player correctly before playing or pausing the audio.

@nimau nimau requested a review from a team as a code owner October 26, 2023 09:57
@nimau nimau requested review from Velin92 and removed request for a team October 26, 2023 09:57
@sonarcloud
Copy link

sonarcloud bot commented Oct 26, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions
Copy link

Warnings
⚠️ Please add a changelog.
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.

Generated by 🚫 Danger Swift against 858e2b6

@codecov
Copy link

codecov bot commented Oct 26, 2023

Codecov Report

Attention: 17 lines in your changes are missing coverage. Please review.

Comparison is base (86bcb82) 68.91% compared to head (858e2b6) 69.04%.
Report is 1 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1965      +/-   ##
===========================================
+ Coverage    68.91%   69.04%   +0.13%     
===========================================
  Files          515      516       +1     
  Lines        35286    35318      +32     
  Branches     17142    17163      +21     
===========================================
+ Hits         24318    24386      +68     
+ Misses       10322    10291      -31     
+ Partials       646      641       -5     
Flag Coverage Δ
unittests 54.20% <82.65%> (+0.15%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...omposerToolbar/View/CompletionSuggestionView.swift 91.13% <100.00%> (ø)
...Screens/ComposerToolbar/View/ComposerToolbar.swift 76.57% <100.00%> (+0.85%) ⬆️
...oserToolbar/View/VoiceMessagePreviewComposer.swift 62.50% <100.00%> (ø)
...mposerToolbar/View/VoiceMessageRecordingView.swift 93.75% <100.00%> (+1.85%) ⬆️
...ocationSharing/StaticLocationScreenViewModel.swift 93.10% <100.00%> (ø)
...s/VoiceMessages/VoiceMessageRoomPlaybackView.swift 48.71% <100.00%> (-2.35%) ⬇️
...urces/Screens/RoomScreen/RoomScreenViewModel.swift 49.40% <0.00%> (ø)
...ources/Other/VoiceMessage/VoiceMessageButton.swift 89.23% <89.23%> (ø)
...ne/TimelineController/RoomTimelineController.swift 39.82% <0.00%> (-0.36%) ⬇️

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nimau nimau merged commit 8a5986f into develop Oct 26, 2023
10 checks passed
@nimau nimau deleted the nicolas/voice-message-fix-forward branch October 26, 2023 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants