Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Key backup Rust API adoption #1952

Merged
merged 3 commits into from
Oct 27, 2023
Merged

Key backup Rust API adoption #1952

merged 3 commits into from
Oct 27, 2023

Conversation

stefanceriu
Copy link
Member

@stefanceriu stefanceriu commented Oct 24, 2023 •
edited
Loading

Adopt Rust side secure backup APIs (incomplete, based on poljar/backup-pr)

@stefanceriu stefanceriu changed the base branch from develop to stefan/keyBackupReturns October 24, 2023 11:06
@github-actions
Copy link

github-actions bot commented Oct 24, 2023 •
edited
Loading

Warnings
⚠️ Please add a changelog.
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against ea5f400

pixlwave
pixlwave approved these changes Oct 24, 2023
View reviewed changes
Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for now.

ElementX/Sources/FlowCoordinators/UserSessionFlowCoordinator.swift Outdated Show resolved Hide resolved
Base automatically changed from stefan/keyBackupReturns to develop October 24, 2023 15:38
@stefanceriu stefanceriu force-pushed the stefan/keyBackupRustApiAdoption branch from 5c4266c to eacb3a5 Compare October 24, 2023 15:55
@pixlwave pixlwave force-pushed the stefan/keyBackupRustApiAdoption branch from 32fcdd2 to 1bcab01 Compare October 27, 2023 13:29
@pixlwave pixlwave force-pushed the stefan/keyBackupRustApiAdoption branch from 1bcab01 to 2b10ebf Compare October 27, 2023 18:45
@pixlwave
Update with the latest Rust changes.
ea5f400 
The loading button for .unknown was incorrect. It should be treated as disabled.
@sonarcloud
Copy link

sonarcloud bot commented Oct 27, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
10.0% 10.0% Duplication

@pixlwave pixlwave marked this pull request as ready for review October 27, 2023 19:16
@pixlwave pixlwave requested a review from a team as a code owner October 27, 2023 19:16
@pixlwave pixlwave merged commit a837ce5 into develop Oct 27, 2023
5 of 6 checks passed
@pixlwave pixlwave deleted the stefan/keyBackupRustApiAdoption branch October 27, 2023 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pixlwave pixlwave pixlwave approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stefanceriu @pixlwave