Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix playback and recording of voice messages #1948

Merged
merged 7 commits into from
Oct 24, 2023

Conversation

nimau
Copy link
Contributor

@nimau nimau commented Oct 24, 2023

This PR fixes

  • a problem where switching from one voice message playback to another did not update the user interface accordingly
  • an issue where briefly pressing the microphone button while a playback was in progress did not cancel the recording.

@nimau nimau requested a review from a team as a code owner October 24, 2023 07:06
@nimau nimau requested review from alfogrillo and removed request for a team October 24, 2023 07:06
@github-actions
Copy link

github-actions bot commented Oct 24, 2023

Warnings
⚠️ Please add a changelog.
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against 3bdf9aa

@codecov
Copy link

codecov bot commented Oct 24, 2023

Codecov Report

Attention: 78 lines in your changes are missing coverage. Please review.

Comparison is base (c885585) 69.13% compared to head (b4d9080) 69.16%.
Report is 2 commits behind head on develop.

❗ Current head b4d9080 differs from pull request most recent head 3bdf9aa. Consider uploading reports for the commit 3bdf9aa to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1948      +/-   ##
===========================================
+ Coverage    69.13%   69.16%   +0.03%     
===========================================
  Files          509      509              
  Lines        34613    34636      +23     
  Branches     16785    16804      +19     
===========================================
+ Hits         23930    23957      +27     
+ Misses       10062    10059       -3     
+ Partials       621      620       -1     
Flag Coverage Δ
unittests 54.69% <7.14%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...ervices/Audio/Recorder/AudioRecorderProtocol.swift 0.00% <ø> (ø)
...ces/Services/MediaPlayer/MediaPlayerProvider.swift 80.00% <100.00%> (+7.27%) ⬆️
...ne/TimelineController/RoomTimelineController.swift 39.90% <0.00%> (-0.10%) ⬇️
...s/Services/VoiceMessage/VoiceMessageRecorder.swift 80.68% <66.66%> (ø)
...Screens/ComposerToolbar/View/ComposerToolbar.swift 78.20% <0.00%> (+1.97%) ⬆️
...ources/Services/Audio/Recorder/AudioRecorder.swift 3.31% <2.63%> (+0.31%) ⬆️

... and 8 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nimau nimau requested a review from alfogrillo October 24, 2023 13:07
Copy link
Contributor

@alfogrillo alfogrillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I left just a comment to simplify the code.

@nimau nimau force-pushed the nicolas/voice-message-fixes branch from 8fc2386 to 3281f9c Compare October 24, 2023 14:33
@nimau nimau enabled auto-merge (squash) October 24, 2023 14:35
@nimau nimau force-pushed the nicolas/voice-message-fixes branch from 3281f9c to 1a1f94d Compare October 24, 2023 14:59
@nimau nimau force-pushed the nicolas/voice-message-fixes branch from 1a1f94d to 95b6d33 Compare October 24, 2023 15:48
@sonarcloud
Copy link

sonarcloud bot commented Oct 24, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@nimau nimau merged commit f9ad44f into develop Oct 24, 2023
6 checks passed
@nimau nimau deleted the nicolas/voice-message-fixes branch October 24, 2023 16:49
@stefanceriu
Copy link
Member

Fix EncryptedHistoryRoomTimelineView test preview

Oupsie, thanks Nicolas! 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants