-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix playback and recording of voice messages #1948
Conversation
Generated by 🚫 Danger Swift against 3bdf9aa |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #1948 +/- ##
===========================================
+ Coverage 69.13% 69.16% +0.03%
===========================================
Files 509 509
Lines 34613 34636 +23
Branches 16785 16804 +19
===========================================
+ Hits 23930 23957 +27
+ Misses 10062 10059 -3
+ Partials 621 620 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
ElementX/Sources/Screens/ComposerToolbar/View/ComposerToolbar.swift
Outdated
Show resolved
Hide resolved
ElementX/Sources/Services/MediaPlayer/MediaPlayerProvider.swift
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, I left just a comment to simplify the code.
8fc2386
to
3281f9c
Compare
3281f9c
to
1a1f94d
Compare
1a1f94d
to
95b6d33
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Fix EncryptedHistoryRoomTimelineView test preview Oupsie, thanks Nicolas! 😅 |
This PR fixes