Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SwiftUI timeline tweaks #1425

Merged
merged 3 commits into from
Jul 31, 2023
Merged

SwiftUI timeline tweaks #1425

merged 3 commits into from
Jul 31, 2023

Conversation

stefanceriu
Copy link
Member

Delay rendering bottom timeline items when scrolled up and avoid content shifts

  • builds on top of langleyd/timeline_defer_new_items
  • improve animations

@stefanceriu
Delay rendering bottom timeline items when scrolled up and avoid cont…
3307cae 
…ent shifts

- builds on top of langleyd/timeline_defer_new_items
- improve animations
@stefanceriu stefanceriu requested a review from a team as a code owner July 31, 2023 10:36
@stefanceriu stefanceriu requested review from pixlwave and removed request for a team July 31, 2023 10:36
@stefanceriu stefanceriu changed the title Stefan/swift timeline tweaks SwiftUI timeline tweaks Jul 31, 2023
@github-actions
Copy link

github-actions bot commented Jul 31, 2023 •
edited
Loading

Warnings
⚠️ Please add a changelog.
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
⚠️ You seem to have made changes to views. Please consider adding screenshots.
⚠️

ElementX/Sources/Screens/RoomScreen/RoomScreenViewModel.swift#L505 - SwiftLint rule 'function_body_length' did not trigger a violation in the disabled region. Please remove the disable command. (superfluous_disable_command)
⚠️

ElementX/Sources/Services/Room/RoomSummary/RoomSummaryProvider.swift#L210 - SwiftLint rule 'function_body_length' did not trigger a violation in the disabled region. Please remove the disable command. (superfluous_disable_command)

Generated by 🚫 Danger Swift against df1be47

pixlwave
pixlwave approved these changes Jul 31, 2023
View reviewed changes
Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable to me 👍

ElementX/Sources/Screens/RoomScreen/RoomScreenViewModel.swift Outdated Show resolved Hide resolved
ElementX/Sources/Screens/RoomScreen/View/TimelineView.swift Show resolved Hide resolved
ElementX/Sources/Screens/RoomScreen/RoomScreenViewModel.swift Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Jul 31, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@stefanceriu stefanceriu merged commit 6bf36b2 into develop Jul 31, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pixlwave pixlwave pixlwave approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stefanceriu @pixlwave