Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DM avatars not showing up in room headers. Use the roomListItem a… #1422

Merged
merged 2 commits into from
Jul 28, 2023

Conversation

stefanceriu
Copy link
Member

…vatar instead of the fullRoom one.

@stefanceriu stefanceriu requested a review from a team as a code owner July 28, 2023 15:14
@stefanceriu stefanceriu requested review from alfogrillo and removed request for a team July 28, 2023 15:14
@stefanceriu stefanceriu enabled auto-merge (rebase) July 28, 2023 15:15
@github-actions
Copy link

github-actions bot commented Jul 28, 2023

Warnings
⚠️ Please add a changelog.
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.

Generated by 🚫 Danger Swift against 6b7fe45

@codecov
Copy link

codecov bot commented Jul 28, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.11% 🎉

Comparison is base (07651bd) 54.30% compared to head (10f4f2d) 54.42%.
Report is 1 commits behind head on develop.

❗ Current head 10f4f2d differs from pull request most recent head 6b7fe45. Consider uploading reports for the commit 6b7fe45 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1422      +/-   ##
===========================================
+ Coverage    54.30%   54.42%   +0.11%     
===========================================
  Files          393      393              
  Lines        25413    25413              
  Branches     12881    12881              
===========================================
+ Hits         13800    13830      +30     
+ Misses       11248    11216      -32     
- Partials       365      367       +2     
Flag Coverage Δ
unittests 22.88% <0.00%> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
ElementX/Sources/Services/Room/RoomProxy.swift 21.48% <0.00%> (ø)

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sonarcloud
Copy link

sonarcloud bot commented Jul 28, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@stefanceriu stefanceriu merged commit 62f78fb into develop Jul 28, 2023
5 checks passed
@stefanceriu stefanceriu deleted the stefan/roomHeaderAvatar branch July 28, 2023 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants