Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify ElementX target for coverage in integrations plan. #1398

Merged
merged 1 commit into from
Jul 27, 2023

Conversation

pixlwave
Copy link
Member

@pixlwave pixlwave commented Jul 25, 2023

This PR update coverage collecting to match UI tests (specify only the EX target) along with clearing derived data on each run as the Integration tests appeared to be uploading coverage from the UI tests.

@pixlwave pixlwave force-pushed the doug/integration-tests-coverage branch from 16b4f89 to 1706580 Compare July 25, 2023 13:24
@github-actions
Copy link

github-actions bot commented Jul 25, 2023

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.

Generated by 🚫 Danger Swift against 04f9c2d

@codecov
Copy link

codecov bot commented Jul 25, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.10% 🎉

Comparison is base (0e7a48d) 45.49% compared to head (04f9c2d) 45.60%.
Report is 1 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1398      +/-   ##
===========================================
+ Coverage    45.49%   45.60%   +0.10%     
===========================================
  Files          396      396              
  Lines        25667    25671       +4     
  Branches     13027    13029       +2     
===========================================
+ Hits         11678    11706      +28     
+ Misses       13695    13670      -25     
- Partials       294      295       +1     
Flag Coverage Δ
unittests 22.92% <0.00%> (+0.15%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
ElementX/Sources/Application/AppSettings.swift 96.15% <ø> (ø)
...erOptionsScreen/DeveloperOptionsScreenModels.swift 0.00% <ø> (ø)
...perOptionsScreen/View/DeveloperOptionsScreen.swift 0.00% <0.00%> (ø)

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pixlwave pixlwave force-pushed the doug/integration-tests-coverage branch 2 times, most recently from f40d055 to 6260a5e Compare July 27, 2023 13:42
@sonarcloud
Copy link

sonarcloud bot commented Jul 27, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@pixlwave pixlwave force-pushed the doug/integration-tests-coverage branch from 6260a5e to 04f9c2d Compare July 27, 2023 14:37
@pixlwave pixlwave marked this pull request as ready for review July 27, 2023 14:38
@pixlwave pixlwave requested a review from a team as a code owner July 27, 2023 14:38
@pixlwave pixlwave requested review from stefanceriu and removed request for a team July 27, 2023 14:38
Copy link
Member

@stefanceriu stefanceriu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 it!

@pixlwave pixlwave enabled auto-merge (squash) July 27, 2023 14:40
@pixlwave pixlwave disabled auto-merge July 27, 2023 15:03
@pixlwave pixlwave merged commit 07651bd into develop Jul 27, 2023
7 checks passed
@pixlwave pixlwave deleted the doug/integration-tests-coverage branch July 27, 2023 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants