Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add expand/collapse UI for reactions #1249

Merged
merged 7 commits into from
Jul 10, 2023

Commits on Jul 5, 2023

  1. Add expand/collapse UI for reactions

    - Adds a CollapsibleFlowLayout for controlling the layout
    - Adds tests for  this layout and some mocks for testing layouts generally
    - Improves the rendering of the reaction buttons which were not pixel perfect
    - Adds the UI for the expand collapse buttons including the count of hidden items in the collapsed state.
    langleyd committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    ec08796 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    3a41ea6 View commit details
    Browse the repository at this point in the history
  3. Remove Flow and simplify implementation

    - Remove SwiftUI-Flow
    - Add strings by importing from Localyse
    - Remove count on expand button as requires GeometryReader and can cause loops
    - Don't use GeometryReader for hiding reactions with opacity(just put them way off screen for now)
    - Fix unit and UI tests
    langleyd committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    0e456e0 View commit details
    Browse the repository at this point in the history
  4. Merge branch 'develop' of https://github.com/vector-im/element-x-ios

    …into langleyd/reactions_expand_collapse
    langleyd committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    4afada8 View commit details
    Browse the repository at this point in the history

Commits on Jul 6, 2023

  1. Merge branch 'develop' of https://github.com/vector-im/element-x-ios

    …into langleyd/reactions_expand_collapse
    langleyd committed Jul 6, 2023
    Configuration menu
    Copy the full SHA
    36b3ef4 View commit details
    Browse the repository at this point in the history

Commits on Jul 10, 2023

  1. Address PR comments

    - use synthesized inits
    - use rows rather than lines for naming flow layout
    - other naming improvements
    - reactions were already rendered in another ui test, removing my test on favour of those and updating the screenshots for those.
    langleyd committed Jul 10, 2023
    Configuration menu
    Copy the full SHA
    d9bf448 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    aa7cabd View commit details
    Browse the repository at this point in the history