updated tests

ElementX.xcodeproj/project.pbxproj

@@ -696,6 +696,7 @@
  9BD3A773186291560DF92B62 /* RoomTimelineProvider.swift in Sources */ = {isa = PBXBuildFile; fileRef = 66F2402D738694F98729A441 /* RoomTimelineProvider.swift */; };
  9C4EC28A921486B1775D7F8C /* IdentityConfirmedScreen.swift in Sources */ = {isa = PBXBuildFile; fileRef = 307702DD66E7DDCDD9214784 /* IdentityConfirmedScreen.swift */; };
  9C55746D8F6A3E35CFCF4A7A /* AuthenticationStartLogo.swift in Sources */ = {isa = PBXBuildFile; fileRef = 598F01EBD0C4CC550C644418 /* AuthenticationStartLogo.swift */; };
+ 9CBB04365408F9D6F46BA3A7 /* PinnedEventsTimelineFlowCoordinator.swift in Sources */ = {isa = PBXBuildFile; fileRef = A54AAF72E821B4084B7E4298 /* PinnedEventsTimelineFlowCoordinator.swift */; };
  9D2E03DB175A6AB14589076D /* AnalyticsEvents in Frameworks */ = {isa = PBXBuildFile; productRef = 2A3F7BCCB18C15B30CCA39A9 /* AnalyticsEvents */; };
  9D79B94493FB32249F7E472F /* PlaceholderAvatarImage.swift in Sources */ = {isa = PBXBuildFile; fileRef = C705E605EF57C19DBE86FFA1 /* PlaceholderAvatarImage.swift */; };
  9D9690D2FD4CD26FF670620F /* AppDelegate.swift in Sources */ = {isa = PBXBuildFile; fileRef = C75EF87651B00A176AB08E97 /* AppDelegate.swift */; };
@@ -745,7 +746,6 @@
  A6F345328CCC5C9B0DAE2257 /* LogViewerScreenViewModel.swift in Sources */ = {isa = PBXBuildFile; fileRef = 0BB05221D7D941CC82DC8480 /* LogViewerScreenViewModel.swift */; };
  A722F426FD81FC67706BB1E0 /* CustomLayoutLabelStyle.swift in Sources */ = {isa = PBXBuildFile; fileRef = 42236480CF0431535EBE8387 /* CustomLayoutLabelStyle.swift */; };
  A74438ED16F8683A4B793E6A /* AnalyticsSettingsScreenViewModel.swift in Sources */ = {isa = PBXBuildFile; fileRef = 0BCE3FAF40932AC7C7639AC4 /* AnalyticsSettingsScreenViewModel.swift */; };
- A778A1BF2C74AB2300D5539E /* PinnedEventsTimelineFlowCoordinator.swift in Sources */ = {isa = PBXBuildFile; fileRef = A778A1BE2C74AB2300D5539E /* PinnedEventsTimelineFlowCoordinator.swift */; };
  A7D48E44D485B143AADDB77D /* Strings+Untranslated.swift in Sources */ = {isa = PBXBuildFile; fileRef = 1A18F6CE4D694D21E4EA9B25 /* Strings+Untranslated.swift */; };
  A808DC3F72D15C6C5A52317E /* TimelineItemDebugView.swift in Sources */ = {isa = PBXBuildFile; fileRef = BCDA016D05107DED3B9495CB /* TimelineItemDebugView.swift */; };
  A816F7087C495D85048AC50E /* RoomMemberDetailsScreenModels.swift in Sources */ = {isa = PBXBuildFile; fileRef = 1B6E30BB748F3F480F077969 /* RoomMemberDetailsScreenModels.swift */; };
@@ -1870,14 +1870,14 @@
  A436057DBEA1A23CA8CB1FD7 /* UIFont+AttributedStringBuilder.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = "UIFont+AttributedStringBuilder.h"; sourceTree = "<group>"; };
  A443FAE2EE820A5790C35C8D /* et */ = {isa = PBXFileReference; lastKnownFileType = text.plist.strings; name = et; path = et.lproj/Localizable.strings; sourceTree = "<group>"; };
  A4A1003A0F7A1DFB47F4E2D0 /* TimelineItemMock.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = TimelineItemMock.swift; sourceTree = "<group>"; };
+ A54AAF72E821B4084B7E4298 /* PinnedEventsTimelineFlowCoordinator.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = PinnedEventsTimelineFlowCoordinator.swift; sourceTree = "<group>"; };
  A58E93D91DE3288010390DEE /* EmojiDetectionTests.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = EmojiDetectionTests.swift; sourceTree = "<group>"; };
  A69869844D2B6F5BD9AABF85 /* OIDCConfigurationProxy.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = OIDCConfigurationProxy.swift; sourceTree = "<group>"; };
  A6B19D10B102956066AF117B /* PollOptionView.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = PollOptionView.swift; sourceTree = "<group>"; };
  A6B891A6DA826E2461DBB40F /* PHGPostHogConfiguration.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = PHGPostHogConfiguration.swift; sourceTree = "<group>"; };
  A6C11AD9813045E44F950410 /* ElementCallWidgetDriverProtocol.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = ElementCallWidgetDriverProtocol.swift; sourceTree = "<group>"; };
  A6EA0D8B0BBD8805F7D5A133 /* TextBasedRoomTimelineViewProtocol.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = TextBasedRoomTimelineViewProtocol.swift; sourceTree = "<group>"; };
  A73A07BAEDD74C48795A996A /* AsyncSequence.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = AsyncSequence.swift; sourceTree = "<group>"; };
- A778A1BE2C74AB2300D5539E /* PinnedEventsTimelineFlowCoordinator.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = PinnedEventsTimelineFlowCoordinator.swift; sourceTree = "<group>"; };
  A7C4EA55DA62F9D0F984A2AE /* CollapsibleTimelineItem.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = CollapsibleTimelineItem.swift; sourceTree = "<group>"; };
  A7D452AF7B5F7E3A0A7DB54C /* SessionVerificationScreenViewModelProtocol.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = SessionVerificationScreenViewModelProtocol.swift; sourceTree = "<group>"; };
  A7E37072597F67C4DD8CC2DB /* ComposerDraftServiceProtocol.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = ComposerDraftServiceProtocol.swift; sourceTree = "<group>"; };
@@ -3437,12 +3437,12 @@
  A9B069D7772DDF6513E0F1B8 /* AuthenticationFlowCoordinator.swift */,
  7367B3B9A8CAF902220F31D1 /* BugReportFlowCoordinator.swift */,
  C3285BD95B564CA2A948E511 /* OnboardingFlowCoordinator.swift */,
+ A54AAF72E821B4084B7E4298 /* PinnedEventsTimelineFlowCoordinator.swift */,
  9A008E57D52B07B78DFAD1BB /* RoomFlowCoordinator.swift */,
  0833F51229E166BCA141D004 /* RoomRolesAndPermissionsFlowCoordinator.swift */,
  D28F7A6CEEA4A2815B0F0F55 /* SettingsFlowCoordinator.swift */,
  C99FDEEB71173C4C6FA2734C /* UserSessionFlowCoordinator.swift */,
  E8774CF614849664B5B3C2A1 /* UserSessionFlowCoordinatorStateMachine.swift */,
- A778A1BE2C74AB2300D5539E /* PinnedEventsTimelineFlowCoordinator.swift */,
  );
  path = FlowCoordinators;
  sourceTree = "<group>";
@@ -6399,7 +6399,6 @@
  558E2673B04FDD06A1A12DD3 /* LogViewerScreenViewModelProtocol.swift in Sources */,
  872A6457DF573AF8CEAE927A /* LoginHomeserver.swift in Sources */,
  CEB8FB1269DE20536608B957 /* LoginMode.swift in Sources */,
- A778A1BF2C74AB2300D5539E /* PinnedEventsTimelineFlowCoordinator.swift in Sources */,
  5375902175B2FEA2949D7D74 /* LoginScreen.swift in Sources */,
  651341E67C3514F9811A1EC1 /* LoginScreenCoordinator.swift in Sources */,
  C5A07E2D88BE7D51DCECD166 /* LoginScreenModels.swift in Sources */,
@@ -6507,6 +6506,7 @@
  7708976CEE6AFB5CFAEFBA68 /* PillTextAttachment.swift in Sources */,
  8C050A8012E6078BEAEF5BC8 /* PillTextAttachmentData.swift in Sources */,
  7E2BB42805C59DB57E95610F /* PillView.swift in Sources */,
+ 9CBB04365408F9D6F46BA3A7 /* PinnedEventsTimelineFlowCoordinator.swift in Sources */,
  5D52925FEB1B780C65B0529F /* PinnedEventsTimelineScreen.swift in Sources */,
  E184FFAD32342D3D6E2F89AA /* PinnedEventsTimelineScreenCoordinator.swift in Sources */,
  FEC03105D1BDE0F49BD7F243 /* PinnedEventsTimelineScreenModels.swift in Sources */,

ElementX/Sources/Screens/Timeline/TimelineViewModel.swift

@@ -95,6 +95,10 @@ class TimelineViewModel: TimelineViewModelType, TimelineViewModelProtocol {
  showFocusLoadingIndicator()
  }
 
+ Task {
+ await updatePinnedEventIDs()
+ }
+
  setupSubscriptions()
  setupDirectRoomSubscriptionsIfNeeded()
 
@@ -377,9 +381,6 @@ class TimelineViewModel: TimelineViewModelType, TimelineViewModelProtocol {
  .actionsPublisher
  .filter { $0 == .roomInfoUpdate }
  Task { [weak self] in
- // Don't guard let self here, otherwise the for await will strongify the self reference creating a strong reference cycle.
- // If the subscription has sent a value before the Task has started it might be lost, so before entering the loop we always do an update.
- await self?.updatePinnedEventIDs()
  for await _ in roomInfoSubscription.receive(on: DispatchQueue.main).values {
  guard !Task.isCancelled else {
  return

UnitTests/Sources/RoomScreenViewModelTests.swift

@@ -117,9 +117,8 @@ class RoomScreenViewModelTests: XCTestCase {
  // setup a way to inject the mock of the pinned events timeline
  let pinnedTimelineMock = TimelineProxyMock()
  let pinnedTimelineProviderMock = RoomTimelineProviderMock()
- let providerUpdateSubject = PassthroughSubject<([TimelineItemProxy], PaginationState), Never>()
- pinnedTimelineProviderMock.underlyingUpdatePublisher = providerUpdateSubject.eraseToAnyPublisher()
  pinnedTimelineMock.timelineProvider = pinnedTimelineProviderMock
+ pinnedTimelineProviderMock.underlyingUpdatePublisher = Empty<([TimelineItemProxy], PaginationState), Never>().eraseToAnyPublisher()
  pinnedTimelineProviderMock.itemProxies = [.event(.init(item: EventTimelineItemSDKMock(configuration: .init(eventID: "test1")), id: "1")),
  .event(.init(item: EventTimelineItemSDKMock(configuration: .init(eventID: "test2")), id: "2")),
  .event(.init(item: EventTimelineItemSDKMock(configuration: .init(eventID: "test3")), id: "3"))]