Apply suggestions from code review

Co-authored-by: Doug <[email protected]>
element-hq · Oct 17, 2024 · acfb954 · acfb954
1 parent d995e87
commit acfb954
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 6 deletions.
diff --git a/ElementX/Sources/Mocks/KnockedRoomProxyMock.swift b/ElementX/Sources/Mocks/KnockedRoomProxyMock.swift
@@ -22,7 +22,7 @@ extension KnockedRoomProxyMock {
  self.init()
  id = configuration.id
  name = configuration.name
- avatarURL = avatarURL
+ avatarURL = configuration.avatarURL
  avatar = .room(id: configuration.id, name: configuration.name, avatarURL: configuration.avatarURL) // Note: This doesn't replicate the real proxy logic.
  activeMembersCount = configuration.members.filter { $0.membership == .join || $0.membership == .invite }.count
  }

diff --git a/ElementX/Sources/Screens/JoinRoomScreen/View/JoinRoomScreen.swift b/ElementX/Sources/Screens/JoinRoomScreen/View/JoinRoomScreen.swift
@@ -78,9 +78,8 @@ struct JoinRoomScreen: View {
  }
 
  if context.viewState.mode == .knock {
- Spacer()
- .frame(height: 19)
  knockMessage
+ .padding(.top, 19)
  }
  }
  }
@@ -118,9 +117,11 @@ struct JoinRoomScreen: View {
  }
  .background(.compound.bgCanvasDefault)
  .cornerRadius(8)
- .overlay(RoundedRectangle(cornerRadius: 8)
- .inset(by: 0.5)
- .stroke(.compound.borderInteractivePrimary))
+ .overlay {
+ RoundedRectangle(cornerRadius: 8)
+ .inset(by: 0.5)
+ .stroke(.compound.borderInteractivePrimary)
+ }
 
  Text(L10n.screenJoinRoomKnockMessageDescription)
  .font(.compound.bodyMD)