Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use CryptoApi.getKeyBackupInfo instead of deprecated MatrixClient.getKeyBackupVersion #28450

Merged
merged 4 commits into from
Nov 25, 2024
Merged

Use CryptoApi.getKeyBackupInfo instead of deprecated MatrixClient.getKeyBackupVersion #28450

merged 4 commits into from
Nov 25, 2024

Conversation

florianduros
Copy link
Member

@florianduros florianduros commented Nov 12, 2024 •
edited
Loading

Checklist

  • Tests written for new code (and old code if feasible).
  • New or updated public/exported symbols have accurate TSDoc documentation.
  • Linter and other CI checks pass.
  • I have licensed the changes to Element by completing the Contributor License Agreement (CLA)

Task #26922
Blocked by matrix-org/matrix-js-sdk#4534

Use CryptoApi.getKeyBackupInfo instead of deprecated MatrixClient.getKeyBackupVersion

@florianduros florianduros mentioned this pull request Nov 12, 2024
Open
@florianduros florianduros added the T-Task Tasks for the team like planning label Nov 12, 2024
@florianduros florianduros force-pushed the florianduros/rip-out-legacy-crypto/migrate-getBackupVersion branch from 031d997 to 1e3aa43 Compare November 18, 2024 14:26
@florianduros florianduros force-pushed the florianduros/rip-out-legacy-crypto/migrate-getBackupVersion branch from 1e3aa43 to 43645b3 Compare November 21, 2024 13:58
@florianduros florianduros marked this pull request as ready for review November 21, 2024 14:48
@florianduros florianduros requested review from a team as code owners November 21, 2024 14:48
t3chguy
t3chguy approved these changes Nov 21, 2024
View reviewed changes
src/DeviceListener.ts Outdated Show resolved Hide resolved
src/components/structures/MatrixChat.tsx Outdated Show resolved Hide resolved
src/components/views/dialogs/security/RestoreKeyBackupDialog.tsx Outdated Show resolved Hide resolved
src/components/views/settings/SecureBackupPanel.tsx Outdated Show resolved Hide resolved
src/stores/SetupEncryptionStore.ts Outdated Show resolved Hide resolved
@andybalaam andybalaam removed the request for review from uhoreg November 25, 2024 09:29
@florianduros florianduros added this pull request to the merge queue Nov 25, 2024
Merged via the queue into develop with commit ede91bf Nov 25, 2024
32 checks passed
@florianduros florianduros deleted the florianduros/rip-out-legacy-crypto/migrate-getBackupVersion branch November 25, 2024 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t3chguy t3chguy t3chguy approved these changes

@andybalaam andybalaam andybalaam approved these changes

@MidhunSureshR MidhunSureshR Awaiting requested review from MidhunSureshR MidhunSureshR is a code owner automatically assigned from element-hq/element-web-reviewers

@robintown robintown Awaiting requested review from robintown robintown is a code owner automatically assigned from element-hq/element-web-reviewers

Assignees
No one assigned
Labels
T-Task Tasks for the team like planning
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@florianduros @andybalaam @t3chguy