Playwright: deflake verification tests #28289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wait for the QR code to be rendered, in an attempt to deflake these two
t3chguy
approved these changes
Oct 24, 2024
richvdh
commented
Oct 24, 2024
Comment on lines
+119
to
+121
| // ... and confirm. We expect the verification to fail; we catch the error on the DOM side | ||
| // to stop playwright marking the evaluate as failing in the UI. | ||
| const botVerification = botVerifier.evaluate((verifier) => verifier.verify().catch(() => {})); |
There was a problem hiding this comment.
this is a driveby cleanup, not really related to the deflaking.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wait for the QR code to be rendered, in an attempt to deflake these two
Fixes: #27819
Fixes: #27789