Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Excluding floating-ui portals as part of hiding tooltips in Playwright screenshots #28287

Merged
merged 2 commits into from
Oct 28, 2024
Merged

Excluding floating-ui portals as part of hiding tooltips in Playwright screenshots #28287

merged 2 commits into from
Oct 28, 2024

Conversation

t3chguy
Copy link
Member

@t3chguy t3chguy commented Oct 24, 2024

No description provided.

@t3chguy t3chguy added the T-Task Tasks for the team like planning label Oct 24, 2024
@t3chguy
Update screenshot
a87807b 
Signed-off-by: Michael Telatynski <[email protected]>
@t3chguy t3chguy self-assigned this Oct 24, 2024
@t3chguy t3chguy marked this pull request as ready for review October 24, 2024 10:26
@t3chguy t3chguy requested a review from a team as a code owner October 24, 2024 10:26
@t3chguy t3chguy requested review from dbkr and robintown October 24, 2024 10:26
dbkr
dbkr approved these changes Oct 28, 2024
View reviewed changes
Copy link
Member

@dbkr dbkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Slightly surprising that the release announcement is the only thing we have that tests floating UI, but yay, not sure why we didn't do this before. This should help with a bunch of flakes.

@florianduros
Copy link
Member

@dbkr We did it https://github.com/element-hq/element-web/blob/develop/playwright/element-web-test.ts#L346. However since the last huge compound upgrade (and the way we are using the compound tooltip), we don't have anymore the role tooltip.

@t3chguy t3chguy added this pull request to the merge queue Oct 28, 2024
Merged via the queue into develop with commit 954ff0a Oct 28, 2024
38 checks passed
@t3chguy t3chguy deleted the t3chguy/stable-playwright-tooltips branch October 28, 2024 11:25
@t3chguy t3chguy mentioned this pull request Oct 31, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbkr dbkr dbkr approved these changes

@robintown robintown Awaiting requested review from robintown robintown is a code owner automatically assigned from element-hq/element-web-reviewers

Assignees

@t3chguy t3chguy

Labels
T-Task Tasks for the team like planning
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@t3chguy @florianduros @dbkr