Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace MatrixClient.isRoomEncrypted by MatrixClient.CryptoApi.isEncryptionEnabledInRoom in SecurityRoomSettingsTab #28281

Merged
merged 1 commit into from
Oct 24, 2024
Merged

Replace MatrixClient.isRoomEncrypted by MatrixClient.CryptoApi.isEncryptionEnabledInRoom in SecurityRoomSettingsTab #28281

merged 1 commit into from
Oct 24, 2024

Conversation

florianduros
Copy link
Member

Checklist

  • Tests written for new code (and old code if feasible).
  • New or updated public/exported symbols have accurate TSDoc documentation.
  • Linter and other CI checks pass.
  • I have licensed the changes to Element by completing the Contributor License Agreement (CLA)

Task #26922

@florianduros
Replace MatrixClient.isRoomEncrypted by `MatrixClient.CryptoApi.isE…
844c484 
…ncryptionEnabledInRoom` in `SecurityRoomSettingsTab`
@florianduros florianduros mentioned this pull request Oct 23, 2024
Open
@florianduros florianduros added the T-Task Tasks for the team like planning label Oct 23, 2024
@florianduros florianduros marked this pull request as ready for review October 23, 2024 17:07
@florianduros florianduros requested a review from a team as a code owner October 23, 2024 17:07
@florianduros florianduros added this pull request to the merge queue Oct 24, 2024
Merged via the queue into develop with commit 6d0d237 Oct 24, 2024
42 of 43 checks passed
@florianduros florianduros deleted the florianduros/rip-out-legacy-crypto/migrate-securityrooomtab-isroomencrypted branch October 24, 2024 08:51
@florianduros florianduros mentioned this pull request Nov 25, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t3chguy t3chguy t3chguy approved these changes

@MidhunSureshR MidhunSureshR Awaiting requested review from MidhunSureshR MidhunSureshR is a code owner automatically assigned from element-hq/element-web-reviewers

Assignees
No one assigned
Labels
T-Task Tasks for the team like planning
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@florianduros @t3chguy