Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flake in pinned message e2e test due to tooltip #28257

Merged

Conversation

florianduros
Copy link
Member

Checklist

  • Tests written for new code (and old code if feasible).
  • New or updated public/exported symbols have accurate TSDoc documentation.
  • Linter and other CI checks pass.
  • I have licensed the changes to Element by completing the Contributor License Agreement (CLA)

Closes #27950

@florianduros florianduros added the T-Task Tasks for the team like planning label Oct 21, 2024
Copy link
Member

@t3chguy t3chguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A mask doesn't de-flake a component which is sometimes visible sometimes not, as now you'll sometimes have a pink box and sometimes blank

@florianduros florianduros added this pull request to the merge queue Oct 21, 2024
Merged via the queue into develop with commit 5e59492 Oct 21, 2024
38 checks passed
@florianduros florianduros deleted the florianduros/fix-pinned-message-test-flake-tooltip branch October 21, 2024 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-Task Tasks for the team like planning
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flaky playwright test: pinned-messages/pinned-messages.spec.ts: should unpin all messages
2 participants