Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow hiding invite messages from timeline #28247

Closed
wants to merge 1 commit into from

Conversation

RavuAlHemio
Copy link

@RavuAlHemio RavuAlHemio commented Oct 19, 2024

Checklist

  • Tests written for new code (and old code if feasible).
  • New or updated public/exported symbols have accurate TSDoc documentation.
  • Linter and other CI checks pass. -- PR requires approval from maintainer to run CI checks
  • I have licensed the changes to Element by completing the Contributor License Agreement (CLA)

@github-actions github-actions bot added the Z-Community-PR Issue is solved by a community member's PR label Oct 19, 2024
@RavuAlHemio RavuAlHemio marked this pull request as ready for review October 19, 2024 20:26
@RavuAlHemio RavuAlHemio requested a review from a team as a code owner October 19, 2024 20:26
@RavuAlHemio RavuAlHemio requested review from dbkr and robintown October 19, 2024 20:26
@t3chguy t3chguy requested a review from a team October 21, 2024 08:13
@dbkr
Copy link
Member

dbkr commented Oct 21, 2024

Thanks for your PR! Here's the next steps to getting this merged:

  • Product signoff: we'll need to decide whether this is a thing we're willing to support in the product. Making an enhancement issue would help for this as the template will give you prompts for the necessary information.
  • Tests

@RavuAlHemio
Copy link
Author

#28252 is the requested enhancement issue; tests are a work in progress.

@RavuAlHemio
Copy link
Author

I have added relevant tests. They might be brittle if invites become summarized in the future, though...

@RavuAlHemio RavuAlHemio force-pushed the hide-invite branch 3 times, most recently from 4ebd8bb to 590ef74 Compare October 26, 2024 11:11
@langleyd
Copy link
Member

langleyd commented Dec 16, 2024

I've discussed this with product and it is not a setting we are looking to add at the moment. If anything we would like to have less settings in future. We will however look to improve the timeline experience such that less of them are needed.

@langleyd langleyd closed this Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Z-Community-PR Issue is solved by a community member's PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants