Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor CreateCrossSigningDialog #28218

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

Refactor CreateCrossSigningDialog #28218

wants to merge 4 commits into from
+393 −161

Conversation

dbkr
Copy link
Member

@dbkr dbkr commented Oct 17, 2024

  • Converts CreateCrossSigningDialog to a functional component
  • Pulls logic out to its own class
  • Updates usage of deprecated cross signing bootstrap method on client to be on the crypto object and updates test to match

Moved from element-hq/matrix-react-sdk#131

Checklist

  • Tests written for new code (and old code if feasible).
  • New or updated public/exported symbols have accurate TSDoc documentation.
  • Linter and other CI checks pass.
  • I have licensed the changes to Element by completing the Contributor License Agreement (CLA)

@dbkr
Refactor CreateCrossSigningDialog
dcba7c7 
 * Converts CreateCrossSigningDialog to a functional component
 * Pulls logic out to its own class
 * Updates usage of deprecated cross signing bootstrap method on client to be on the crypto object and updates test to match

Moved from element-hq/matrix-react-sdk#131
@dbkr dbkr added the T-Task Tasks for the team like planning label Oct 17, 2024
@dbkr dbkr marked this pull request as ready for review October 17, 2024 11:30
@dbkr dbkr requested review from a team as code owners October 17, 2024 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BillCarsonFr BillCarsonFr Awaiting requested review from BillCarsonFr BillCarsonFr is a code owner automatically assigned from element-hq/element-crypto-web-reviewers

@florianduros florianduros Awaiting requested review from florianduros florianduros is a code owner automatically assigned from element-hq/element-web-reviewers

@MidhunSureshR MidhunSureshR Awaiting requested review from MidhunSureshR MidhunSureshR is a code owner automatically assigned from element-hq/element-web-reviewers

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
T-Task Tasks for the team like planning
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@dbkr