Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove MatrixClient.requestVerification call #28208

Conversation

florianduros
Copy link
Member

@florianduros florianduros commented Oct 16, 2024

Checklist

  • Tests written for new code (and old code if feasible).
  • New or updated public/exported symbols have accurate TSDoc documentation.
  • Linter and other CI checks pass.
  • I have licensed the changes to Element by completing the Contributor License Agreement (CLA)

Task #26922
hasCrossSigningKeys is a condition to display the verify button. The falsy condition can't be reached.

t3chguy and others added 9 commits October 16, 2024 13:31
Co-authored-by: github-merge-queue <[email protected]>
Co-authored-by: github-merge-queue <[email protected]>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Florian Duros <[email protected]>
Co-authored-by: Kim Brose <[email protected]>
Co-authored-by: Florian Duros <[email protected]>
Co-authored-by: R Midhun Suresh <[email protected]>
Co-authored-by: dbkr <[email protected]>
Co-authored-by: ElementRobot <[email protected]>
Co-authored-by: dbkr <[email protected]>
Co-authored-by: David Baker <[email protected]>
Co-authored-by: Michael Telatynski <[email protected]>
Co-authored-by: Richard van der Hoff <[email protected]>
Co-authored-by: David Langley <[email protected]>
Co-authored-by: Michael Weimann <[email protected]>
Co-authored-by: Timshel <[email protected]>
Co-authored-by: Sahil Silare <[email protected]>
Co-authored-by: Will Hunt <[email protected]>
Co-authored-by: Hubert Chathi <[email protected]>
Co-authored-by: Andrew Ferrazzutti <[email protected]>
Co-authored-by: Robin <[email protected]>
Co-authored-by: Tulir Asokan <[email protected]>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
* Remove `VerificationExplorer`

* Remove `remakeolm` slash command

* Remove call to `crypto.cancelAndResendAllOutgoingKeyRequests`

* Remove crypto mock in `LoginWithQR-test.tsx`

* Remove `StopGadWidgetDriver.sendToDevice`

* Remove remaining mock
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@florianduros florianduros added the T-Task Tasks for the team like planning label Oct 16, 2024
@florianduros florianduros force-pushed the florianduros/rip-out-legacy-crypto/remove-requestVerification branch from e568bb1 to 5fb100b Compare October 16, 2024 15:17
@florianduros florianduros marked this pull request as ready for review October 16, 2024 15:34
@florianduros florianduros requested a review from a team as a code owner October 16, 2024 15:34
@t3chguy t3chguy requested a review from a team as a code owner October 17, 2024 08:11
@dbkr
Copy link
Member

dbkr commented Oct 17, 2024

Changeset has also gone weird on this one.

@t3chguy
Copy link
Member

t3chguy commented Oct 17, 2024

Resolving conflicts might fix it, or it might prefer a rebase

@florianduros
Copy link
Member Author

Replaced by #28216 (take less time to cherry pick)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-Task Tasks for the team like planning
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants