Add static file .well-known/assetlinks.json #27439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tions Element and Element X running on Android 12 and higher to open external links.
|
You'll need to update other files which reference |
bmarty
commented
May 7, 2024
webpack.config.js
Outdated
| @@ -736,6 +736,7 @@ module.exports = (env, argv) => { | |||
| new CopyWebpackPlugin({ | |||
| patterns: [ | |||
| "res/apple-app-site-association", | |||
| "res/.well-known/assetlinks.json", | |||
There was a problem hiding this comment.
No sure that the file will be copied to the correct destination. Can you confirm @t3chguy ?
Sorry I am a newbie here :)
There was a problem hiding this comment.
It probably won't. I suggest testing it locally.
There was a problem hiding this comment.
Yes, it was not working as expected.
After 095c613 it's fine.
Tested OK using ./scripts/ci_package.sh
|
@florianduros @robintown is there anything else I need to do to make this PR "mergeable"? Thanks! |
|
(merging myself since @bmarty isn't on the contributors team) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add static file .well-known/assetlinks.json to allow Android applications Element and Element X running on Android 12 and higher to open external links with the domains
app.element.io,develop.element.ioandstaging.element.io.This is the Android equivalent of the file https://github.com/element-hq/element-web/blob/develop/res/apple-app-site-association
Epic: https://github.com/element-hq/element-internal/issues/534
Note: I understand that once merged and deployed, the following URLs will return the file which is added by this PR (currently returning 404):
Please let me know if this is not the case!
Thanks.
Checklist
public/exportedsymbols have accurate TSDoc documentation.