Add @nordeck/[email protected] to variants/openDesk/build_config.yaml #26710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uild_config.yaml Signed-off-by: Charly Nguyen <[email protected]>
github-actions
bot
added
Z-Community-PR
|
First of all, thanks for your contribution! @charlynguyen I'm not familiar with this area of element-web. Can you explain why these change are needed ? Thanks |
|
@florianduros we collaborate on openDesk. Basically, we use Element/Matrix and enhance the user experience with our widgets (based on matrix-widget-api) and customisations (based on matrix-react-sdk-module-api). Since you provide a Docker image for openDesk including our modules I think it make sense to add all modules that we have/use for openDesk. You can find our modules here element-web-modules. This PR adds the module that provides some openDesk specific functionality which are described here. I hope this helps! 😄 |
florianduros
approved these changes
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
@nordeck/[email protected]to thevariants/openDesk/build_config.yaml.Checklist
This change is marked as an internal change (Task), so will not be included in the changelog.