Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace copy/watching of non-language assets with copy-webpack-plugin #26599

Merged
merged 4 commits into from
Nov 16, 2023

Conversation

Johennes
Copy link
Contributor

@Johennes Johennes commented Nov 16, 2023

This replaces the homegrown copy-watching of non-language assets in copy-res.ts with https://github.com/webpack-contrib/copy-webpack-plugin.

The only notable difference to the custom script is that the assets are not output into the webapp directory when running the app through the development server. They're still served though. So I think we probably don't care.

Unfortunately, we can't use the latest version of the plugin until we upgrade to Webpack 5.


This change is marked as an internal change (Task), so will not be included in the changelog.

@Johennes Johennes added the T-Task Tasks for the team like planning label Nov 16, 2023
@Johennes Johennes requested review from a team as code owners November 16, 2023 13:25
Copy link
Member

@t3chguy t3chguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@Johennes
Copy link
Contributor Author

Hmmm.

ERROR in unable to locate '/Users/runner/work/element-web/element-web/config.json' glob

On all the builds but I'm not getting this locally. Looks like an extra element-web path component. 🤔

@t3chguy
Copy link
Member

t3chguy commented Nov 16, 2023

The file doesn't exist by default, only config.sample.json does - the double path thing is standard, its the name of workspace + name of repo, so the difference was the config.json copy was previously allowed to not exist

@Johennes
Copy link
Contributor Author

The file doesn't exist by default, only config.sample.json does - the double path thing is standard, its the name of workspace + name of repo, so the difference was the config.json copy was previously allowed to not exist

Ohhhh. 🤦

Thanks.

@Johennes Johennes merged commit e6f69f7 into develop Nov 16, 2023
18 checks passed
@Johennes Johennes deleted the johannes/copy-webpack-plugin branch November 16, 2023 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-Task Tasks for the team like planning
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants