Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update webpack to 4.47.0 / webpack-cli to 4.10.0 / webpack-dev-server 4.15.1 #26216

Merged
merged 7 commits into from
Oct 25, 2023

Conversation

Johennes
Copy link
Contributor

@Johennes Johennes commented Sep 21, 2023

This updates webpack and webpack-cli to the latest 4.x version which is a stopgap towards #26229.

What works

  • yarn build
    • --bail is now a config option instead of a CLI flag
  • yarn start
    • -w has been removed but watching appears to work so I assume this is the new default
    • contentBase is now static.directory
    • stats is now devMiddleware.stats
    • hotOnly: true is now hot: "only"
    • --disable-host-check is now allowedHosts: "all"

Things I'm unsure about

  • We've previously been overriding hotOnly: true with --hot. I think hotOnly is what we want because it auto-refreshes after build failures. Therefore, I've removed --hot
  • The --output-... options seem to have been removed. In turn --output-path webapp appears to be required. webpack-cli 4.3.0 has broken auto bundling bhauman/figwheel-main#278 (comment) indicates that this might be a result of combining webpack 4 with webpack-cli 4.

This change is marked as an internal change (Task), so will not be included in the changelog.

@Johennes Johennes added the T-Task Tasks for the team like planning label Sep 21, 2023
@Johennes Johennes changed the title Update webpack to 4.47.0 / webpack-cli to 4.10.0 Update webpack to 4.47.0 / webpack-cli to 4.10.0 / webpack-dev-server 4.15.1 Sep 22, 2023
@Johennes Johennes mentioned this pull request Sep 23, 2023
39 tasks
@Johennes Johennes marked this pull request as ready for review October 24, 2023 12:29
@Johennes Johennes requested review from a team as code owners October 24, 2023 12:29
@Johennes
Copy link
Contributor Author

Johennes commented Oct 24, 2023

Given that #26229 will continue to be blocked on element-hq/compound-web#116 for at least another two weeks, I think this PR here can go ahead in the meantime. I'm adding a few more folks for review because, even though this PR is quite small, webpack is a finicky area.

@germain-gg germain-gg removed their request for review October 25, 2023 07:07
@richvdh richvdh removed their request for review October 25, 2023 12:52
@Johennes Johennes merged commit de2d3ff into develop Oct 25, 2023
15 checks passed
@Johennes Johennes deleted the johannes/webpack-cli-4.10.0 branch October 25, 2023 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-Task Tasks for the team like planning
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants