Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Implement 'Knocking` #22925

Closed
wants to merge 0 commits into from
Closed

Conversation

ankur12-1610
Copy link
Contributor

@ankur12-1610 ankur12-1610 commented Jul 23, 2022

Checklist

  • Tests written for new code (and old code if feasible)
  • Linter and other CI checks pass
  • Sign-off given on the changes (see CONTRIBUTING.md)

This PR is the part of PR: #9093


This PR currently has none of the required changelog labels.

A reviewer can add one of: T-Deprecation, T-Enhancement, T-Defect, T-Task to indicate what type of change this is, or add Type: [enhancement/defect/task] to the description and I'll add them for you.

@ankur12-1610 ankur12-1610 force-pushed the knocking branch 2 times, most recently from f2baa46 to a154b25 Compare July 24, 2022 10:57
@ankur12-1610
Copy link
Contributor Author

@SimonBrandner I've done yarn i18n still the check is failing is there any reason for it?

@SimonBrandner
Copy link
Contributor

@SimonBrandner I've done yarn i18n still the check is failing is there any reason for it?

You need to revert the changes you've done to the non en_EN.json files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants