Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Element-R keeps sending and resending the same to-device for room keys #26382

Closed
BillCarsonFr opened this issue Oct 17, 2023 · 3 comments · Fixed by matrix-org/matrix-rust-sdk-crypto-wasm#41 or matrix-org/matrix-js-sdk#3811
Closed

Element-R keeps sending and resending the same to-device for room keys #26382

BillCarsonFr opened this issue Oct 17, 2023 · 3 comments · Fixed by matrix-org/matrix-rust-sdk-crypto-wasm#41 or matrix-org/matrix-js-sdk#3811
Assignees
@BillCarsonFr
Labels
A-Element-R Issues affecting the port of Element's crypto layer to Rust T-Defect Z-Element-R-Blocker A blocker for enabling Element R by default Z-Labs

Comments

@BillCarsonFr
Copy link
Member

Steps to reproduce

  1. Open the browser devtools
  2. Send a message in an encrypted room
  3. Send a second message

Outcome

What did you expect?

Keys are sent as to device the first time, then no more sharing

What happened instead?

Keeps sending with same transaction id and same content
image

Mark request as sent on the olm machine is never called:
image

Operating system

macOS

Browser information

No response

URL for webapp

No response

Application version

No response

Homeserver

No response

Will you send logs?

Yes
@BillCarsonFr BillCarsonFr added T-Defect Z-Element-R-Blocker A blocker for enabling Element R by default labels Oct 17, 2023
@BillCarsonFr
Copy link
Member Author

Might be a cause of #26375

@BillCarsonFr
Copy link
Member Author

Will unblock matrix-org/matrix-js-sdk#3790

Notice that recipient is not getting the redondant messages as they have the same transaction id, so synapse ignores them

@BillCarsonFr BillCarsonFr added the A-Element-R Issues affecting the port of Element's crypto layer to Rust label Oct 17, 2023
@BillCarsonFr BillCarsonFr mentioned this issue Oct 17, 2023
Merged
@richvdh richvdh changed the title Element-R keep sending and resending the same to-device for room keys Element-R keeps sending and resending the same to-device for room keys Oct 18, 2023
@richvdh richvdh mentioned this issue Oct 19, 2023
Closed
@BillCarsonFr BillCarsonFr mentioned this issue Oct 19, 2023
Merged
3 tasks
@BillCarsonFr
Copy link
Member Author

Will be fixed when the binding version is updated matrix-org/matrix-js-sdk#3811

@BillCarsonFr BillCarsonFr reopened this Oct 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BillCarsonFr BillCarsonFr

Labels
A-Element-R Issues affecting the port of Element's crypto layer to Rust T-Defect Z-Element-R-Blocker A blocker for enabling Element R by default Z-Labs
Projects
None yet
Milestone
No milestone
2 participants
@germain-gg @BillCarsonFr