Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Element-R: keys imported from backup are backed up again #26347

Closed
richvdh opened this issue Oct 10, 2023 · 2 comments · Fixed by matrix-org/matrix-js-sdk#3934
Closed

Element-R: keys imported from backup are backed up again #26347

richvdh opened this issue Oct 10, 2023 · 2 comments · Fixed by matrix-org/matrix-js-sdk#3934
Assignees
@uhoreg
Labels
A-Element-R Issues affecting the port of Element's crypto layer to Rust O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Z-Element-R-Blocker A blocker for enabling Element R by default Z-Labs

Comments

@richvdh
Copy link
Member

richvdh commented Oct 10, 2023

We will attempt to re-upload any keys that are imported from key backup, which is a waste.
@richvdh richvdh added T-Defect A-Element-R Issues affecting the port of Element's crypto layer to Rust labels Oct 10, 2023
@richvdh
Copy link
Member Author

richvdh commented Oct 10, 2023

cf TODO at https://github.com/matrix-org/matrix-js-sdk/blob/develop/src/rust-crypto/rust-crypto.ts#L348

@weeman1337 weeman1337 added S-Minor Impairs non-critical functionality or suitable workarounds exist O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience Z-Labs labels Oct 10, 2023
@richvdh richvdh mentioned this issue Nov 1, 2023
Closed
@BillCarsonFr BillCarsonFr added the Z-Element-R-Blocker A blocker for enabling Element R by default label Nov 8, 2023
@richvdh richvdh mentioned this issue Nov 9, 2023
Merged
@richvdh
Copy link
Member Author

richvdh commented Nov 10, 2023

matrix-org/matrix-rust-sdk-crypto-wasm#54 adds a new method to the bindings to help with this

@uhoreg uhoreg self-assigned this Nov 21, 2023
@uhoreg uhoreg mentioned this issue Nov 30, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@uhoreg uhoreg

Labels
A-Element-R Issues affecting the port of Element's crypto layer to Rust O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Z-Element-R-Blocker A blocker for enabling Element R by default Z-Labs
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Don't back up keys that we got from backup uhoreg/matrix-js-sdk
4 participants
@uhoreg @richvdh @weeman1337 @BillCarsonFr