Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

App should remember whether the space panel was expanded #23172

Open
ara4n opened this issue Aug 31, 2022 · 3 comments
Open

App should remember whether the space panel was expanded #23172

ara4n opened this issue Aug 31, 2022 · 3 comments
Labels
A-Spaces Spaces, groups, communities A-Subspaces Spaces which are inside other spaces good first issue Good for newcomers Hacktoberfest Issues which are suitable for Hacktoberfest PRs: https://hacktoberfest.digitalocean.com/ Help Wanted Extra attention is needed O-Occasional Affects or can be seen by some users regularly or most users rarely T-Enhancement

Comments

@ara4n
Copy link
Member

ara4n commented Aug 31, 2022

Steps to reproduce

  1. Minimise the spacepanel & leftpanel
  2. Un-minimise them again
  3. Restart the app (an upgrade, in this instance)
  4. Observe that the app launches with minimised spacepanel & leftpanel

Outcome

What did you expect?

Panel layout should persist across layouts

What happened instead?

Something failed to save when i expanded the panel layouts, it seems.

Operating system

macOS

Application version

nightly

How did you install the app?

nightly

Homeserver

matrix.org

Will you send logs?

No
@ara4n ara4n added the T-Defect label Aug 31, 2022
@robintown
Copy link
Member

robintown commented Sep 1, 2022 •
edited
Loading

The app has never tried to remember whether the space panel should be expanded, so that part would be an enhancement

@robintown robintown changed the title Panel layout broke across restart App should remember whether the space panel was expanded Sep 1, 2022
@robintown
Copy link
Member

robintown commented Sep 1, 2022 •
edited
Loading

The left panel bug is filed separately as #23188

@robintown robintown added A-Spaces Spaces, groups, communities T-Enhancement O-Occasional Affects or can be seen by some users regularly or most users rarely A-Subspaces Spaces which are inside other spaces good first issue Good for newcomers and removed T-Defect labels Sep 1, 2022
@gefgu gefgu mentioned this issue Sep 5, 2022
Closed
3 tasks
@kittykat kittykat added the Help Wanted Extra attention is needed label Sep 23, 2022
clarkf added a commit to clarkf/matrix-react-sdk that referenced this issue Jan 11, 2023
@clarkf
Remember collapsed state in <SpacePanel />
6ce1244 
Stash the collapsed state in a setting, which is persisted in localStorage
between loads.

See element-hq/element-web#23172

Signed-off-by: Clark Fischer <[email protected]>
@clarkf clarkf mentioned this issue Jan 11, 2023
Closed
3 tasks
clarkf added a commit to clarkf/matrix-react-sdk that referenced this issue Jan 11, 2023
@clarkf
Remember collapsed state in <SpacePanel />
ebedc80 
Stash the collapsed state in a setting, which is persisted in localStorage
between loads.

See element-hq/element-web#23172

Signed-off-by: Clark Fischer <[email protected]>
@Johennes Johennes added the Hacktoberfest Issues which are suitable for Hacktoberfest PRs: https://hacktoberfest.digitalocean.com/ label Oct 24, 2023
@ArchitGajjar
Copy link

Hi @ara4n - is this issue still open ? can I work on this issue ? Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Spaces Spaces, groups, communities A-Subspaces Spaces which are inside other spaces good first issue Good for newcomers Hacktoberfest Issues which are suitable for Hacktoberfest PRs: https://hacktoberfest.digitalocean.com/ Help Wanted Extra attention is needed O-Occasional Affects or can be seen by some users regularly or most users rarely T-Enhancement
Projects
None yet
Milestone
No milestone
5 participants
@kittykat @Johennes @ara4n @ArchitGajjar @robintown